Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: inform AsyncProducer Close pitfalls #2001

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

HurSungYun
Copy link
Contributor

Not closing AsyncProducer before process shutting down seems a common mistake when using it.

I believe it is worth to inform users that messages can be lost if they omit to call Close() when using AsyncProducer.

@HurSungYun HurSungYun requested a review from bai as a code owner August 30, 2021 12:53
@ghost ghost added the cla-needed label Aug 30, 2021
@HurSungYun HurSungYun closed this Aug 30, 2021
@HurSungYun HurSungYun reopened this Aug 30, 2021
@HurSungYun HurSungYun changed the title docs: update AsyncProducer Close pitfalls docs: inform AsyncProducer Close pitfalls Aug 30, 2021
@HurSungYun
Copy link
Contributor Author

I've signed CLA :)

@ghost ghost removed the cla-needed label Aug 31, 2021
@bai
Copy link
Contributor

bai commented Sep 7, 2021

Thanks for your contribution! 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants