Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the TLS connection state of a broker connection #2051

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

seveas
Copy link
Contributor

@seveas seveas commented Oct 14, 2021

I'm adding kafka support to a piece of monitoring software that does protocol-level checks but also does tls verification beyond what net/tls does. For this to work the software needs access to the tls connection state. net/smtp and go-ldap expose this in the same way.

Similar to how net/smtp and others do this, this gives one access to tls
state date without having to expose the underlying connection. This is
useful for e.g. monitoring software.
@seveas seveas requested a review from bai as a code owner October 14, 2021 10:45
@ghost ghost added the cla-needed label Oct 14, 2021
@seveas
Copy link
Contributor Author

seveas commented Oct 14, 2021

I have now signed the CLA, but don't seem to be able to re-run the check.

@ghost ghost removed the cla-needed label Oct 15, 2021
@bai bai requested a review from dnwe November 19, 2021 06:32
@bai
Copy link
Contributor

bai commented Jan 21, 2022

Thanks for contributing! This change looks good to me - thoughts @dnwe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants