Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logger: fix debug logs' formatting directives #2054

Merged
merged 1 commit into from
Nov 6, 2021

Conversation

utrack
Copy link
Contributor

@utrack utrack commented Oct 29, 2021

Default DebugLogger had broken Printf directives -
for DebugLogger.Printf(fmt,A,B,C) it called Logger.Printf(fmt,[A B C]),
which resulted in logs like

client/coordinator coordinator for consumergroup [topicname
%!s(int32=1) host:9094] is #%!d(MISSING) (%!s(MISSING))

This commit fixes value passing for Printf.

Default DebugLogger had broken Printf directives -
for DebugLogger.Printf(fmt,A,B,C) it called Logger.Printf(fmt,[A B C]),
which resulted in logs like
```
client/coordinator coordinator for consumergroup [topicname
%!s(int32=1) host:9094] is #%!d(MISSING) (%!s(MISSING))
```

This commit fixes value passing for Printf.
@utrack utrack requested a review from bai as a code owner October 29, 2021 09:42
@ghost ghost added the cla-needed label Oct 29, 2021
@utrack
Copy link
Contributor Author

utrack commented Oct 29, 2021

@bai I've just signed the CLA, not sure how to rerun the checkbot.

@ghost ghost removed the cla-needed label Oct 29, 2021
Copy link
Collaborator

@dnwe dnwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants