fix: ignore non-nil but empty error strings in Describe/Alter client quotas responses #2096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting. We should check the broker source to see when/why this changed. This also suggests we need DescribeClientQuotas coverage in the functional_test suite too |
agriffaut
force-pushed
the
bug/issue-2095
branch
2 times, most recently
from
83271fc
to
581f074
Compare
agriffaut
force-pushed
the
bug/issue-2095
branch
from
581f074
to
cf02615
Compare
|
Hi @dnwe i added some integration tests which covers describe / alter / delete of client quotas, thanks for your feedbacks ! |
dnwe
changed the title
|
@agriffaut fantastic! thank you for doing that, changes and tests LGTM — approving and merging |
dnwe
approved these changes
Jan 4, 2022
This was referenced Jan 19, 2022
This was referenced Apr 19, 2022
fix(deps): update module github.com/shopify/sarama to v1.32.0
secustor/opentelemetry-meetup#41
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That PR resolve issue #2095, it has been tested against Kafka 2.7.0 and Kafka 2.8.1