Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): make it simpler to re-use toxiproxy #2122

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Conversation

dnwe
Copy link
Collaborator

@dnwe dnwe commented Jan 31, 2022

Sometimes it is convenient to re-use the docker containers between runs of an FV test. The existing support for supplying a pre-existing TOXIPROXY_ADDR was a little flakey. Tidy up functional_test.go so that it will getOrCreate the toxiproxy routes to the kafka brokers. Then you can just manually docker-compose up -d before running a given test yourself and prevent the teardown at the end.

This is particularly useful for people who have migrated away from docker desktop to limavm and want to use lima nerdctl compose locally.

Sometimes it is convenient to re-use the docker containers between runs
of an FV test. The existing support for supplying a pre-existing
TOXIPROXY_ADDR was a little flakey. Tidy up functional_test.go so that
it will getOrCreate the toxiproxy routes to the kafka brokers. Then you
can just manually `docker-compose up -d` before running a given test
yourself and prevent the teardown at the end.

This is particularly useful for people who have migrated away from
docker desktop to limavm and want to use `lima nerdctl compose` locally.
@dnwe dnwe requested a review from bai as a code owner January 31, 2022 13:29
@dnwe dnwe added the build label Jan 31, 2022
Copy link
Contributor

@bai bai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants