fix: rework RebalancingMultiplePartitions test #2130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rework this test to be a bit more reliable and wait for the expected message receipts at each stage of the test rather than handling them separately in a goroutine, which was sensitive to timing and made the test a little flakey
This was referenced Feb 24, 2022
This was referenced Apr 19, 2022
fix(deps): update module github.com/shopify/sarama to v1.32.0
secustor/opentelemetry-meetup#41
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rework this test to be a bit more reliable and wait for the expected
message receipts at each stage of the test rather than handling them
separately in a goroutine, which was sensitive to timing and made the
test a little flakey