Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return underlying sasl error message #2164

Merged
merged 2 commits into from
Feb 27, 2022
Merged

fix: return underlying sasl error message #2164

merged 2 commits into from
Feb 27, 2022

Commits on Feb 27, 2022

  1. fix: return underlying sasl error message 

    The SASL Authentication response message from Kafka has an additional
field which can contain a description of why the authentication failed.
Currently we drop this in Sarama and just return a generic message based
on the kError code.
    @dnwe
    dnwe committed Feb 27, 2022
    Configuration menu
    Copy the full SHA
    f1fd15e View commit details
    Browse the repository at this point in the history

  2. fix: reduce verbosity and whitespace of multierror 

    Add a customised default implementation of the multierror format func
that is less verbose for single error multierrors (return them without
the unnecessary "1 error occured:" prefix) and also condenses the output
by removing one of the newline separators from between multiple errors
in the output.
    @dnwe
    dnwe committed Feb 27, 2022
    Configuration menu
    Copy the full SHA
    f436782 View commit details
    Browse the repository at this point in the history