KIP-368 : Allow SASL Connections to Periodically Re-Authenticate #2197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-wall
force-pushed
the
kip-368
branch
3 times, most recently
from
94a0874
to
88b1c46
Compare
|
The tests that are failing on Go 1.18/Kafka 2.8.1 TestFuncConsumerGroupPartitioningStateful don't appear to be related to my change. |
mimaison
reviewed
Apr 6, 2022
| @@ -1288,6 +1298,10 @@ func (b *Broker) sendAndReceiveV1SASLPlainAuth() error { | |||
| return nil | |||
| } | |||
|
|
|||
| func currentUnixMilli() int64 { | |||
| return time.Now().UnixNano() / int64(time.Millisecond) | |||
There was a problem hiding this comment.
The project aims at supporting the last couple of Golang version, so we could use time.Now().UnixMilli() that was introduced in 1.17. That said, it may be preferable to keep the current code for now to support older environments.
There was a problem hiding this comment.
The project is still on go 1.16, so I cannot adopt this API yet. Also, if I understand the project's "two releases and two months" right it'd be too soon to bump Go right now (1.18 only came out last month (March 2022), so it is too soon for the project to adopt 1.17).
Allow SASL Connections to Periodically Re-Authenticate [KIP-368](https://cwiki.apache.org/confluence/display/KAFKA/KIP-368%3A+Allow+SASL+Connections+to+Periodically+Re-Authenticate)
dnwe
approved these changes
Apr 13, 2022
This was referenced May 11, 2022
This was referenced Aug 31, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for #2060.
If the server uses KIP-368, the client will cause itself to reauthenticate by emitting the necessary SASL handshake/authenticate with the next client to server interaction.