Ensembles: don't expect OptimizerResult.id to be convertible to int

[dweindl]

Fixes Ensemble.from_optimization_{history,endpoints}, which incorrectly assumed that OptimizerResult.id is always convertible to int.

Closes #1349.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.03%. Comparing base (ace9b8b) to head (e6e45d3).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1351      +/-   ##
===========================================
- Coverage    84.22%   83.03%   -1.20%     
===========================================
  Files          157      157              
  Lines        12870    12870              
===========================================
- Hits         10840    10686     -154     
- Misses        2030     2184     +154     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dilpath]

Agreed, looks like the IDs are used as a string elsewhere too

pyPESTO/pypesto/result/optimize.py

Lines 335 to 339 in 34e89b3

	new_ids = {
	prefix + identifier
	for identifier in optimize_result.id
	if identifier is not None
	}

pyPESTO/pypesto/optimize/util.py

Lines 169 to 171 in 34e89b3

	if ids is None:
	i = 0
	ids = [str(j) for j in range(0, n_starts)]

[m-philipps]

Looks fine to me, thanks

[PaulJonasJost]

LGTM, thanks 🙏🏼