Connect Button resume state fixes #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We actually need it to be nullable to represent cases where onNewIntent is called from non-redirect. In this case, we should not try to force the ConnectButton to be in either initial state or the email state.
To account for an issue caused by redirecting to Gmail: the app is temporarily moved back to foreground, and onResume is going to be called. With the ActivityLifecycleCallbacks registered, the onActivityOnResume is going to be called, and we are going to try to restore the button state, which is incorrect. Adding an extra reset knob background step to account for this.
priyaashah
approved these changes
Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make ConnectResult nullable from the
ConnectResult.fromIntent()methodWe actually need it to be nullable to represent cases where onNewIntent is called from non-redirect. In this case, we should not try to force the ConnectButton to be in either initial state or the email state.
Reset knob background when running complete animation
To account for an issue caused by redirecting to Gmail: the app is temporarily moved back to foreground, and onResume is going to be called. With the ActivityLifecycleCallbacks registered, the onActivityOnResume is going to be called, and we are going to try to restore the button state, which is incorrect.
Adding an extra reset knob background step to account for this.