Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styles for widgets with "rev" class for "Reverse" background #77

Open
2 tasks
benlk opened this issue Oct 22, 2019 · 3 comments
Open
2 tasks

Styles for widgets with "rev" class for "Reverse" background #77

benlk opened this issue Oct 22, 2019 · 3 comments
Labels
Estimate: <2 Priority: Low Nice-to-have in a release.

Comments

@benlk
Copy link
Collaborator

benlk commented Oct 22, 2019

Seen in the sidebar of https://citylimits.org/2017/10/09/native-groups-weigh-in-on-the-columbus-controversy/ is a widget with a blue background. This is from Largo's widget options.

  • choose an appropriate background color from within the brand palette
  • apply it
@MirandaEcho
Copy link
Collaborator

@ben - is this something that's also in the new design for article pages? If its not we'll just remove those sections.

@benlk benlk added the Priority: Low Nice-to-have in a release. label Oct 29, 2019
@benlk
Copy link
Collaborator Author

benlk commented Nov 11, 2019

Largo provides "Default", "Reverse" and "No Background". We'd probably want to add a "Beige (for ads)" background color. Largo doesn't provide a filter to add new options to this array, so we'd need to reimplement this code:

https://github.com/INN/largo/blob/512da701664b329f2f92244bbe54880a6e146431/inc/widgets.php#L131-L163

@benlk
Copy link
Collaborator Author

benlk commented Nov 13, 2019

Existing .rev styles:

Screen Shot 2019-11-13 at 14 39 52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Estimate: <2 Priority: Low Nice-to-have in a release.
Projects
None yet
Development

No branches or pull requests

2 participants