Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subscribe button to global and sticky nav #71

Merged
merged 1 commit into from
Mar 4, 2020

Conversation

joshdarby
Copy link

@joshdarby joshdarby commented Mar 3, 2020

Changes

This pull request makes the following changes:

Desktop:
Screen Shot 2020-03-03 at 1 43 14 PM

Sticky:
Screen Shot 2020-03-03 at 1 50 03 PM

Mobile:
Screen Shot 2020-03-03 at 1 43 26 PM

Why

For #66

Testing/Questions

Features that this PR affects:

  • Global and sticky nav

Questions that need to be answered before merging:

  • Is this PR targeting the correct branch in this repository?
  • Is /subscribe/ the correct page to point the button to?

Steps to test this PR:

  1. View the global and sticky navs on desktop and mobile and make sure it looks ok

@joshdarby joshdarby added this to the MISS-009 Support Retainer milestone Mar 3, 2020
@joshdarby joshdarby requested a review from benlk March 3, 2020 18:51
@joshdarby joshdarby self-assigned this Mar 3, 2020
@benlk
Copy link
Collaborator

benlk commented Mar 4, 2020

Note that WPBuddy/largo#1848 will make this so much better in the future.

Copy link
Collaborator

@benlk benlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code on this looks good, but I don't have an answer to this question:

Is /subscribe/ the correct page to point the button to?

@MirandaEcho, can you check with them to see if that's the correct URL?

@joshdarby joshdarby merged commit 1b06aaf into master Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants