-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 Enhances Product parsing to strip whitespaces in host_regex #6419
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6419 +/- ##
=========================================
- Coverage 84.5% 82.5% -2.1%
=========================================
Files 10 595 +585
Lines 214 30413 +30199
Branches 25 260 +235
=========================================
+ Hits 181 25094 +24913
- Misses 23 5259 +5236
- Partials 10 60 +50
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you forgot to put the t:maintenance label
Quality Gate passedIssues Measures |
What do these changes do?
The configuration of the products are currently set directly in the database via adminer. I found that it is easy to make a mistake and introduce spaces in
Product.host_regex
which lead to the system not delivering the right product.This PR ensures that the Product pre-validator trims all leading and trailing whitespaces in the regex entry
Related issue/s
Maintenance
How to test
Dev-ops checklist