Changed level from error to warn on refresh token (#2695)

Expired tokens Invalid tokens
IdentityServer · Nov 4, 2018 · 40288f7 · 40288f7
1 parent 619760e
commit 40288f7
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 3 deletions.
diff --git a/src/Validation/Default/TokenRequestValidator.cs b/src/Validation/Default/TokenRequestValidator.cs
@@ -484,7 +484,7 @@ private async Task<TokenRequestValidationResult> ValidateRefreshTokenRequestAsyn
 
             if (result.IsError)
             {
-                LogError("Refresh token validation failed. aborting.");
+                LogWarning("Refresh token validation failed. aborting.");
                 return Invalid(OidcConstants.TokenErrors.InvalidGrant);
             }
 
@@ -766,6 +766,26 @@ private void LogError(string message = null, params object[] values)
             }
         }
 
+        private void LogWarning(string message = null, params object[] values)
+        {
+            var details = new TokenRequestValidationLog(_validatedRequest);
+            if (message.IsPresent())
+            {
+                try
+                {
+                    _logger.LogWarning(message + ", request details: {details}", values, details);
+                }
+                catch (Exception ex)
+                {
+                    _logger.LogError("Error logging {exception}, request details: {details}", ex.Message, details);
+                }
+            }
+            else
+            {
+                _logger.LogWarning("{details}", details);
+            }
+        }
+
         private void LogInfo(string message = null, params object[] values)
         {
             var details = new TokenRequestValidationLog(_validatedRequest);

diff --git a/src/Validation/Default/TokenValidator.cs b/src/Validation/Default/TokenValidator.cs
@@ -379,7 +379,7 @@ public async Task<TokenValidationResult> ValidateRefreshTokenAsync(string tokenH
             var refreshToken = await _refreshTokenStore.GetRefreshTokenAsync(tokenHandle);
             if (refreshToken == null)
             {
-                _logger.LogError("Invalid refresh token");
+                _logger.LogWarning("Invalid refresh token");
                 return Invalid(OidcConstants.TokenErrors.InvalidGrant);
             }
 
@@ -388,7 +388,7 @@ public async Task<TokenValidationResult> ValidateRefreshTokenAsync(string tokenH
             /////////////////////////////////////////////
             if (refreshToken.CreationTime.HasExceeded(refreshToken.Lifetime, _clock.UtcNow.DateTime))
             {
-                _logger.LogError("Refresh token has expired. Removing from store.");
+                _logger.LogWarning("Refresh token has expired. Removing from store.");
 
                 await _refreshTokenStore.RemoveRefreshTokenAsync(tokenHandle);
                 return Invalid(OidcConstants.TokenErrors.InvalidGrant);