Make it easier to change the IsActiveAsync bahavior

[ulrichb]

Is your feature request related to a problem? Please describe.

The current ProfileService.IsActiveAsync() API:

IdentityServer4/src/AspNetIdentity/src/ProfileService.cs

Lines 95 to 107 in 4b84868

	public virtual async Task IsActiveAsync(IsActiveContext context)
	{
	var sub = context.Subject?.GetSubjectId();
	if (sub == null) throw new Exception("No subject Id claim present");
	var user = await UserManager.FindByIdAsync(sub);
	if (user == null)
	{
	Logger?.LogWarning("No user found matching subject Id: {0}", sub);
	}
	context.IsActive = user != null;
	}

To extend checks on the user-object one must either override the complete method including the null-checking and logging code or call the base method and load the user again (calling UserManager.FindByIdAsync which hits the database).

Describe the solution you'd like

Please separate the data loading / logging code from the check-predicate.

For example: Extract the context.IsActive = user != null line (106) into a protected virtual member which can be overridden in a derived class. (+ allow it to be "async")

Maybe better extract a boolean-returing predicate (only the user != null part, not the context.IsActive = ... part).

[ulrichb]

Btw, my use case would be:

Task<bool> async CustomIsActivePredicate(user: ApplicationUser) => 
    user != null && !await UserManager.IsLockedOutAsync(user)

[ulrichb]

Just have the same problem when overriding ProfileService.GetProfileDataAsync(). I have to do a second silly UserManager.FindByIdAsync access :/

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[brockallen]

How about something like this:

afb90cb

[brockallen]

PR submitted. please have a look.

[brockallen]

merged? yay!

[ulrichb]

@brockallen Finally found time to upgrade to IS4 4.0 and it works great. Many thanks!

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.