Make these extension methods internal

[davidfowl]

IdentityServer4/src/IdentityServer4/src/Extensions/HttpResponseExtensions.cs

Line 17 in 5a1c1f6

public static class HttpResponseExtensions

Or maybe change the namespace? We’re working on adding some of these methods like WriteJsonAsync and they’ll likely clash (when we do).

Also IdentityServer is so commonly used it’s a less than ideal situation that these names get squatted on.

[leastprivilege]

I agree - they should be in our namespace.

[leastprivilege]

When do you want to add these methods? @davidfowl ?

[davidfowl]

They'll be part of 5.0 (WriteJsonAsync..), not sure about the HTML one.

[aboondeviant]

What about IEnumerableExtensions? These are internal in the Storage project but public in the IdentityServer4 project

IdentityServer4/src/IdentityServer4/src/Extensions/IEnumerableExtensions.cs

Line 14 in 44651be

public static class IEnumerableExtensions

[brockallen]

all done

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.