This repository has been archived by the owner on Jul 31, 2024. It is now read-only.
Log full exceptions when available to aid in debugging #1948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
thanks! |
|
Thanks! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this PR address?
This is related to issue #1946. Made changes to log full exceptions rather than just exception messages. This will aid in debugging since the full exception information, including inner exceptions will be available in logs.
Does this PR introduce a breaking change?
No.
Please check if the PR fulfills these requirements
Unit Tests for the changes have been added (for bug fixes / features)N/AOther information:
I was initially just going to do this in the
ProtectedDataMessageStoreclass, but I found several other places where a full exception could be logged rather than just the exception message.