Skip to content
This repository has been archived by the owner on Jul 31, 2024. It is now read-only.

Updates fluent assertions to v5 and fixes complile errors #2054

Merged

Conversation

Erwinvandervalk
Copy link
Contributor

@Erwinvandervalk Erwinvandervalk commented Feb 6, 2018

What issue does this PR address?
The latest version of fluent assertions has breaking changes in it's api. This PR is meant to update the package to the latest verison and fix any failing tests caused by internal issues.

Does this PR introduce a breaking change?
No, it's purely a change to the tests.

Please check if the PR fulfills these requirements

  • The commit follows our guidelines
  • Unit Tests for the changes have been added (for bug fixes / features)

Other information:

@dnfclas
Copy link

dnfclas commented Feb 6, 2018

CLA assistant check
All CLA requirements met.

@Erwinvandervalk Erwinvandervalk changed the title [Wip] Updates fluent assertions to v5 and fixes complile errors Updates fluent assertions to v5 and fixes complile errors Feb 6, 2018
@Erwinvandervalk
Copy link
Contributor Author

@leastprivilege You mentioned earlier that you got runtime errors when upgrading to fluent assertions 5. I only got compile time errors that, after I fixed them, seemed to work fine. Did I overlook anything?

@leastprivilege leastprivilege added this to the 2.1.2 milestone Feb 6, 2018
@leastprivilege
Copy link
Member

thanks!

@leastprivilege leastprivilege merged commit 98326a3 into IdentityServer:dev Feb 6, 2018
@dennisdoomen
Copy link

@Erwinvandervalk thanks for taking the time to upgrade.

@lock
Copy link

lock bot commented Jan 10, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants