Add descscription to client #2282
Conversation
| @@ -8,9 +8,19 @@ | |||
| <div class="client-logo"><img src="@Model.ClientLogoUrl"></div> | |||
There was a problem hiding this comment.
Note. I have urls inserted here and this isnt working due to CORS errors. Not sure what you have been inserting. URL is probably a bad idea on second thought ignore this.
Tweeking the building of the name. Oneline if FTW
| @Model.ClientName | ||
| <small>is requesting your permission</small> | ||
| </h1> | ||
| <h1>@Html.Raw((string.IsNullOrWhiteSpace(Model.ClientUrl))? $"{@Model.ClientName}" : $"<a href='{@Model.ClientUrl}'>{@Model.ClientName}</a>") </h1> |
There was a problem hiding this comment.
I don't like Html.Raw in here -- XSS potential.
There was a problem hiding this comment.
I haven't done web development in 10 years so i am a bit behind in what one should be using.
Do you have a suggestion?
There was a problem hiding this comment.
I'd just write the if/else blocks to build the html tags. The use of Raw disables the HTML encoding of the value.
There was a problem hiding this comment.
I wont have time to do this until Thursday. Up to you if you can wait it looks like your on a clean out PR spree today.
There was a problem hiding this comment.
No, I am just looking at issues. No time yet for me to do any code :)
|
Given that we reworked the models last week, I'll close this and add the description manually. Thanks. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
What issue does this PR address?
2280
Does this PR introduce a breaking change?
nope
Please check if the PR fulfills these requirements
Other information:
Made some changes to the consent screen to display this new info in the Host project. The rest should be pretty basic.