This repository has been archived by the owner on Jul 31, 2024. It is now read-only.
Fix user code param name in DeviceController #3935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaslevesque
commented
Dec 22, 2019
| { | ||
| string userCodeParamName = _options.Value.UserInteraction.DeviceVerificationUserCodeParameter; | ||
| string userCode = Request.Query[userCodeParamName]; |
There was a problem hiding this comment.
Since VerificationUriComplete is generated based on this option, I think it's the only way to properly reflect the configuration
|
@scottbrady91 please review note to self: this must go in both v4 and v3.1.1 |
leastprivilege
pushed a commit
that referenced
this pull request
Dec 24, 2019
(cherry picked from commit f575051)
|
thanks! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this PR address?
Fixes #3923
Does this PR introduce a breaking change?
No. The existing code didn't work as expected.
Please check if the PR fulfills these requirements
(There doesn't seem to be a place where this controller was tested, and adding test infrastructure for it would probably be out of scope for this PR)