Skip to content
This repository has been archived by the owner on Jul 31, 2024. It is now read-only.

Fix UserLoginFailureEvent raised with interactive=true in resource owner grant flow #4240

Merged
merged 2 commits into from
May 7, 2020
Merged

Fix UserLoginFailureEvent raised with interactive=true in resource owner grant flow #4240

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f142b9
Fix UserLoginFailureEvent raised as interactive
ArturDorochowicz Mar 31, 2020
263060b
Improve readability - add parameter name
ArturDorochowicz Mar 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/IdentityServer4/src/Validation/Default/TokenRequestValidator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -809,12 +809,12 @@ private void LogSuccess()

private Task RaiseSuccessfulResourceOwnerAuthenticationEventAsync(string userName, string subjectId, string clientId)
{
return _events.RaiseAsync(new UserLoginSuccessEvent(userName, subjectId, null, false, clientId));
return _events.RaiseAsync(new UserLoginSuccessEvent(userName, subjectId, null, interactive: false, clientId));
}

private Task RaiseFailedResourceOwnerAuthenticationEventAsync(string userName, string error, string clientId)
{
return _events.RaiseAsync(new UserLoginFailureEvent(userName, error, clientId: clientId));
return _events.RaiseAsync(new UserLoginFailureEvent(userName, error, interactive: false, clientId: clientId));
}
}
}