This repository has been archived by the owner on Jul 31, 2024. It is now read-only.
Strict redirect uri validator app auth with path #4245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
brockallen
approved these changes
May 7, 2020
|
Nice, thanks! |
|
This is a great add. I realize it's only the http scheme that the RFC covers - but would it be less safe to also allow https? |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this PR address?
#3974
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
Other information:
This PR is similar to this one but does not use RegEx. It allows for a path in the Loopback address, but does not validate that path.
I'd like to acknowledge VictorioBerra - the unit tests added in this PR are based on the unit tests he wrote in his PR.