Skip to content
This repository has been archived by the owner on Jul 31, 2024. It is now read-only.

Update error handling for invalid response modes #4504

Merged
merged 2 commits into from
Jun 11, 2020
Merged

Update error handling for invalid response modes #4504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c43007
update authorize request validator
leastprivilege Jun 11, 2020
7061546
update tests
leastprivilege Jun 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/IdentityServer4/src/Validation/Default/AuthorizeRequestValidator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,8 +433,8 @@ private AuthorizeRequestValidationResult ValidateCoreParameters(ValidatedAuthori
}
else
{
LogError("Invalid response_mode for flow", responseMode, request);
return Invalid(request, OidcConstants.AuthorizeErrors.UnsupportedResponseType, description: "Invalid response_mode");
LogError("Invalid response_mode for response_type", responseMode, request);
return Invalid(request, OidcConstants.AuthorizeErrors.InvalidRequest, description: "Invalid response_mode for response_type");
}
}
else
Expand Down
2 changes: 1 addition & 1 deletion ...dentityServer4/test/IdentityServer.IntegrationTests/Endpoints/Authorize/AuthorizeTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,7 +685,7 @@ public async Task invalid_response_mode_for_flow_should_show_error_page()
await _mockPipeline.BrowserClient.GetAsync(url);

_mockPipeline.ErrorWasCalled.Should().BeTrue();
_mockPipeline.ErrorMessage.Error.Should().Be(OidcConstants.AuthorizeErrors.UnsupportedResponseType);
_mockPipeline.ErrorMessage.Error.Should().Be(OidcConstants.AuthorizeErrors.InvalidRequest);
_mockPipeline.ErrorMessage.ErrorDescription.Should().Contain("response_mode");
}

Expand Down
14 changes: 7 additions & 7 deletions ....UnitTests/Validation/AuthorizeRequest Validation/Authorize_ProtocolValidation_Invalid.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ public async Task Invalid_ResponseMode_For_IdToken_ResponseType()
var result = await validator.ValidateAsync(parameters);

result.IsError.Should().BeTrue();
result.Error.Should().Be(OidcConstants.AuthorizeErrors.UnsupportedResponseType);
result.Error.Should().Be(OidcConstants.AuthorizeErrors.InvalidRequest);
}

[Fact]
Expand All @@ -257,7 +257,7 @@ public async Task Invalid_ResponseMode_For_IdTokenToken_ResponseType()
var result = await validator.ValidateAsync(parameters);

result.IsError.Should().BeTrue();
result.Error.Should().Be(OidcConstants.AuthorizeErrors.UnsupportedResponseType);
result.Error.Should().Be(OidcConstants.AuthorizeErrors.InvalidRequest);
}

[Fact]
Expand All @@ -275,7 +275,7 @@ public async Task Invalid_ResponseMode_For_CodeToken_ResponseType()
var result = await validator.ValidateAsync(parameters);

result.IsError.Should().BeTrue();
result.Error.Should().Be(OidcConstants.AuthorizeErrors.UnsupportedResponseType);
result.Error.Should().Be(OidcConstants.AuthorizeErrors.InvalidRequest);
}

[Fact]
Expand All @@ -293,7 +293,7 @@ public async Task Invalid_ResponseMode_For_CodeIdToken_ResponseType()
var result = await validator.ValidateAsync(parameters);

result.IsError.Should().BeTrue();
result.Error.Should().Be(OidcConstants.AuthorizeErrors.UnsupportedResponseType);
result.Error.Should().Be(OidcConstants.AuthorizeErrors.InvalidRequest);
}

[Fact]
Expand All @@ -311,7 +311,7 @@ public async Task Invalid_ResponseMode_For_CodeIdTokenToken_ResponseType()
var result = await validator.ValidateAsync(parameters);

result.IsError.Should().BeTrue();
result.Error.Should().Be(OidcConstants.AuthorizeErrors.UnsupportedResponseType);
result.Error.Should().Be(OidcConstants.AuthorizeErrors.InvalidRequest);
}

[Fact]
Expand Down Expand Up @@ -365,7 +365,7 @@ public async Task Invalid_ResponseMode_For_TokenIdToken_ResponseType()
var result = await validator.ValidateAsync(parameters);

result.IsError.Should().BeTrue();
result.Error.Should().Be(OidcConstants.AuthorizeErrors.UnsupportedResponseType);
result.Error.Should().Be(OidcConstants.AuthorizeErrors.InvalidRequest);
}

[Fact]
Expand All @@ -383,7 +383,7 @@ public async Task Invalid_ResponseMode_For_IdTokenCodeToken_ResponseType()
var result = await validator.ValidateAsync(parameters);

result.IsError.Should().BeTrue();
result.Error.Should().Be(OidcConstants.AuthorizeErrors.UnsupportedResponseType);
result.Error.Should().Be(OidcConstants.AuthorizeErrors.InvalidRequest);
}

[Fact]
Expand Down