This repository has been archived by the owner on Jul 31, 2024. It is now read-only.
Introduce LoggingOptions.AuthorizeRequestSensitiveValuesFilter #4744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mustakimali
force-pushed
the
tokenrequestsensitivevaluesfilter
branch
2 times, most recently
from
56e6b67
to
ed4b84a
Compare
We take some sensitive parameters with the "AuthorizeRequest" endpoint with some ICustomAuthorizeRequestValidator implementation to validate them. We don't want those sensitive parameters be logged when the validation fails. This commit introduces `AuthorizeRequestSensitiveValuesFilter` similar to `TokenRequestSensitiveValuesFilter`. This will allow us customize which parameter gets scrubbed.
mustakimali
force-pushed
the
tokenrequestsensitivevaluesfilter
branch
from
ed4b84a
to
6a93eb7
Compare
|
Thanks! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We take some sensitive parameters with the "AuthorizeRequest" endpoint with some ICustomAuthorizeRequestValidator implementation to validate them.
We don't want those sensitive parameters be logged when the validation fails.
This commit introduces
AuthorizeRequestSensitiveValuesFiltersimilar toTokenRequestSensitiveValuesFilter. This will allow us customize which parameter gets scrubbed.