Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(samples): upd samples moving on grid level #2906

Merged
merged 15 commits into from
Feb 15, 2022
Merged

chore(samples): upd samples moving on grid level #2906

merged 15 commits into from
Feb 15, 2022

Conversation

tishko0
Copy link
Contributor

@tishko0 tishko0 commented Dec 10, 2021

fixes #2905

teodosiah
teodosiah requested changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@teodosiah teodosiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Columns' movable property should be removed from the columns collections in the following files:
tree-grid-row-editing-sample.component.ts
tree-grid-rowClasses.component.ts
tree-grid-rowStyle.component.ts

...al-grid-collapsible-column-groups/hierarchical-grid-collapsible-column-groups.component.html Outdated
@@ -34,10 +34,10 @@
<igx-row-island [key]="'Orders'" [autoGenerate]="false">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set row island moving property to 'true', so the columns in the child grids to be movable as before

...l-grid/hierarchical-grid-column-moving-styled/hierarchical-grid-moving-styled.component.html Outdated
@@ -83,25 +83,25 @@
</igx-column>

<igx-row-island [key]="'Orders'" [autoGenerate]="false">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set row island moving property to 'true', so the columns in the child grids to be movable as before

...l-grid/hierarchical-grid-column-moving-styled/hierarchical-grid-moving-styled.component.html Outdated
<igx-column field="ShipAddress"></igx-column>
<igx-column field="ShipCity"></igx-column>
<igx-column field="ShipPostalCode"></igx-column>
<igx-column field="ShipCountry"></igx-column>
<igx-row-island [key]="'OrderDetails'" [autoGenerate]="false">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Row Island moving property should be set to 'true'

...pp/hierarchical-grid/hierarchical-grid-column-moving/hierarchical-grid-moving.component.html Outdated
@@ -83,25 +83,25 @@
</igx-column>

<igx-row-island [key]="'Orders'" [autoGenerate]="false">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Row Island moving property should be set to 'true'

...pp/hierarchical-grid/hierarchical-grid-column-moving/hierarchical-grid-moving.component.html Outdated
<igx-column field="ShipAddress"></igx-column>
<igx-column field="ShipCity"></igx-column>
<igx-column field="ShipPostalCode"></igx-column>
<igx-column field="ShipCountry"></igx-column>
<igx-row-island [key]="'OrderDetails'" [autoGenerate]="false">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Row Island moving property should be set to 'true'

...ltering-load-on-demand/hierarchical-grid-excel-style-filtering-load-on-demand.component.html
<igx-column field="Artist" [sortable]="true"></igx-column>
<igx-column field="Debut" [sortable]="true" [dataType]="'number'"></igx-column>
<igx-column field="GrammyNominations" header="Grammy Nominations" [dataType]="'number'" [sortable]="true"></igx-column>
<igx-column field="GrammyAwards" header="Grammy Awards" [dataType]="'number'" [sortable]="true"></igx-column>
<igx-row-island [key]="'Albums'" [primaryKey]="'Album'" [autoGenerate]="false" [allowFiltering]="true" [filterMode]="'excelStyleFilter'"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Row Island moving property should be set to 'true'

...cel-style-filtering-sample-1/hierarchical-grid-excel-style-filtering-sample-1.component.html Outdated
<igx-column field="GrammyAwards" header="Grammy Awards" dataType="number" [sortable]="true" [movable]="true"></igx-column>
<igx-column field="Debut" [sortable]="true" dataType="number" [formatter]="formatter"></igx-column>
<igx-column field="GrammyNominations" header="Grammy Nominations" dataType="number" [sortable]="true"></igx-column>
<igx-column field="GrammyAwards" header="Grammy Awards" dataType="number" [sortable]="true"></igx-column>

<igx-row-island [key]="'Albums'" [autoGenerate]="false" [allowFiltering]='true' filterMode="excelStyleFilter">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Row Island moving property should be set to 'true'

...rid-excel-style-filtering-style/hierarchical-grid-excel-style-filtering-style.component.html Outdated
<igx-column field="GrammyAwards" header="Grammy Awards" dataType="number" [sortable]="true" [movable]="true"></igx-column>
<igx-column field="Debut" [sortable]="true" dataType="number"></igx-column>
<igx-column field="GrammyNominations" header="Grammy Nominations" dataType="number" [sortable]="true"></igx-column>
<igx-column field="GrammyAwards" header="Grammy Awards" dataType="number" [sortable]="true"></igx-column>

<igx-row-island [key]="'Albums'" [autoGenerate]="false" [allowFiltering]='true' filterMode="excelStyleFilter">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Row Island moving property should be set to 'true'

...cal-grid-multi-column-header-template/hierarchical-grid-multi-column-template.component.html Outdated
@@ -36,10 +36,10 @@
<igx-row-island [key]="'Orders'" [autoGenerate]="false">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Row Island moving property should be set to 'true'

@teodosiah teodosiah self-requested a review December 16, 2021 14:15
teodosiah
teodosiah requested changes Dec 23, 2021
View reviewed changes
...l-grid/hierarchical-grid-column-moving-styled/hierarchical-grid-moving-styled.component.html Outdated
<ng-template igxHeader>
<div class="title-inner">
<span style="float:left">ContactTitle</span>
<igx-icon class="pin-icon" [attr.draggable]="false" family="fas" name="fa-thumbtack" (click)="toggleColumn(contacttitle)"></igx-icon>
</div>
</ng-template>
</igx-column>
<igx-column #address field="Address" [movable]="true">
<igx-column #address field="Address" [moving]="true">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving property should not be set on column-level

@teodosiah teodosiah self-requested a review December 23, 2021 10:48
@teodosiah teodosiah merged commit 9876d83 into vNext Feb 15, 2022
@teodosiah teodosiah deleted the ttonev/samples-2905-vNext branch February 15, 2022 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teodosiah teodosiah teodosiah approved these changes

Assignees
No one assigned
Labels
column moving grid refactoring Use it to mark that the changes made are refactoring. status: awaiting-test status: verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tishko0 @teodosiah