feat(combo): change filter pipe params to accept filteringOptions #7282

IgniteUI · Jul 21, 2020 · fbb7c8a · fbb7c8a
1 parent 4f7ab05
commit fbb7c8a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/projects/igniteui-angular/src/lib/combo/combo.component.html b/projects/igniteui-angular/src/lib/combo/combo.component.html
@@ -51,7 +51,7 @@
         [style.maxHeight.px]="itemsMaxHeight" [igxDropDownItemNavigation]="dropdown" (focus)="dropdown.onFocus()"
         [tabindex]="dropdown.collapsed ? -1 : 0" role="listbox" [attr.id]="dropdown.id">
         <igx-combo-item role="option" [itemHeight]='itemHeight' *igxFor="let item of data
-            | comboFiltering:searchValue:displayKey:filterable:filteringOptions.caseSensitive
+            | comboFiltering:searchValue:displayKey:filterable:filteringOptions
             | comboGrouping:groupKey:valueKey;
             index as rowIndex; containerSize: itemsMaxHeight; scrollOrientation: 'vertical'; itemSize: itemHeight"
             [value]="item" [isHeader]="item.isHeader" [index]="rowIndex">

diff --git a/projects/igniteui-angular/src/lib/combo/combo.pipes.ts b/projects/igniteui-angular/src/lib/combo/combo.pipes.ts
@@ -4,6 +4,7 @@ import { DataUtil } from '../data-operations/data-util';
 import { SortingDirection } from '../data-operations/sorting-expression.interface';
 import { IGX_COMBO_COMPONENT, IgxComboBase } from './combo.common';
 import { DefaultSortingStrategy } from '../data-operations/sorting-strategy';
+import { IComboFilteringOptions } from './combo.component';
 
 
 /**
@@ -13,19 +14,21 @@ import { DefaultSortingStrategy } from '../data-operations/sorting-strategy';
     name: 'comboFiltering'
 })
 export class IgxComboFilteringPipe implements PipeTransform {
-    public transform(collection: any[], searchValue: any, displayKey: any, shouldFilter: boolean, caseSensitive: boolean) {
+    public transform(collection: any[], searchValue: any, displayKey: any,
+                    shouldFilter: boolean, filteringOptions: IComboFilteringOptions) {
         if (!collection) {
             return [];
         }
         if (!searchValue || !shouldFilter) {
             return collection;
         } else {
-            const searchTerm = caseSensitive ? searchValue.trim() : searchValue.toLowerCase().trim();
+            const searchTerm = filteringOptions.caseSensitive ? searchValue.trim() : searchValue.toLowerCase().trim();
             if (displayKey != null) {
-                return collection.filter(e => caseSensitive ? e[displayKey].includes(searchTerm) :
+                return collection.filter(e => filteringOptions.caseSensitive ? e[displayKey].includes(searchTerm) :
                                          e[displayKey].toLowerCase().includes(searchTerm));
             } else {
-                return collection.filter(e => caseSensitive ? e.includes(searchTerm) : e.toLowerCase().includes(searchTerm));
+                return collection.filter(e => filteringOptions.caseSensitive ? e.includes(searchTerm) :
+                                         e.toLowerCase().includes(searchTerm));
             }
         }
     }