Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: Igx tooltip #1710

Closed
Eralmidia opened this issue Jun 26, 2018 · 5 comments
Closed

Feature request: Igx tooltip #1710

Eralmidia opened this issue Jun 26, 2018 · 5 comments
Assignees
@StefanIvanov @simeonoff @tachojelev @desig9stein @SlavUI
Labels
🧰 feature-request tooltip version: 6.2.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@Eralmidia
Copy link

Description

Material style tooltip, similar to https://material.angular.io/components/tooltip/overview
@Eralmidia
Copy link
Author

It would be great if this was templateable as well. So a simple igxTooltip="Some text" easy tooltip for most occasions, but the ability to render html or a full component in a tooltop would also be useful.

@tachojelev tachojelev self-assigned this Aug 23, 2018
@kdinev kdinev added the 🛠️ status: in-development Issues and PRs with active development on them label Sep 4, 2018
tachojelev pushed a commit that referenced this issue Sep 5, 2018
feat(tooltip): initial commit for tooltip #1710
9694e16
tachojelev pushed a commit that referenced this issue Sep 5, 2018
test(tooltip): initial tests and api #1710
ea81548
@tachojelev tachojelev mentioned this issue Sep 5, 2018
Merged
tachojelev pushed a commit that referenced this issue Sep 5, 2018
feat(tooltip): include implementation logic #1710
3ed2b5d
tachojelev pushed a commit that referenced this issue Sep 5, 2018
chore(tooltip): use default class of tooltip in demo #1710
091eff7
tachojelev pushed a commit that referenced this issue Sep 10, 2018
fix(tooltip): prevent opening if closeTooltip is called #1710
57b4cc7
tachojelev pushed a commit that referenced this issue Sep 11, 2018
fix(tooltip): remove redundant cdr and renderer refs #1710
6ee71b8
tachojelev pushed a commit that referenced this issue Sep 12, 2018
test(tooltip): add tests for ING events #1710
0e327e2
tachojelev pushed a commit that referenced this issue Sep 12, 2018
feat(tooltip): add new eventargs and cancelling logic #1710
2f616e8
tachojelev pushed a commit that referenced this issue Sep 12, 2018
fix(tooltip): fix closing event fire even if tooltip isnt visible #1710
9e4da0a
tachojelev pushed a commit that referenced this issue Sep 13, 2018
docs(tooltip): add initial README #1710
098de29
tachojelev pushed a commit that referenced this issue Sep 13, 2018
feat(tooltip): rename igxTooltipAction to igxTooltipTarget #1710
6863c2e
tachojelev pushed a commit that referenced this issue Sep 13, 2018
docs(tooltip): update README #1710
8413bb5
tachojelev pushed a commit that referenced this issue Sep 14, 2018
chore(tooltip): modify tooltip demo #1710
0996e45
tachojelev pushed a commit that referenced this issue Sep 14, 2018
chore(tooltip): add more tooltip demos #1710
3a557da
tachojelev pushed a commit that referenced this issue Sep 17, 2018
fix(tooltip): add & remove aria attributes #1710
aa7180e
tachojelev pushed a commit that referenced this issue Sep 17, 2018
feat(tooltip): add close on escape key logic #1710
669a4ee
tachojelev pushed a commit that referenced this issue Sep 17, 2018
test(tooltip): add close on escape key test #1710
5077484
tachojelev pushed a commit that referenced this issue Sep 19, 2018
test(tooltip): remove unnecessary fix.detectChanges() #1710
0adf899
tachojelev pushed a commit that referenced this issue Sep 19, 2018
docs(tooltip): fix methods' description #1710
53fb1f4
tachojelev pushed a commit that referenced this issue Sep 20, 2018
fix(tooltip): fix hide event firing when show event is cancelled #1710
2a24808
@StefanIvanov
Copy link
Contributor

Link to the spec for the Tooltip

tachojelev pushed a commit that referenced this issue Sep 25, 2018
feat(tooltip): add touch listeners and tests #1710
d57f817
tachojelev pushed a commit that referenced this issue Sep 25, 2018
feat(tooltip): set new open & close animations #1710
415fe10
tachojelev pushed a commit that referenced this issue Sep 26, 2018
test(tooltip): fixing tests #1710
308a5b6
tachojelev pushed a commit that referenced this issue Sep 26, 2018
chore(tooltip): update CHANGELOG #1710
25cd8e4
@Eralmidia
Copy link
Author

Great to see templating is implemented 👍 What exactly does the limitation entail? Do we always have to create a separate DOM element for a tooltip?

@tachojelev tachojelev mentioned this issue Sep 26, 2018
Merged
@tachojelev
Copy link
Contributor

@Eralmidia, we are glad you enjoy the templating functionality.

The answer to your last question is yes. In order to set a tooltip to an element, we need to create a separate DOM element, which represents the tooltip itself. While this is not as convenient as setting a single property for text only tooltips, it makes the templating, styling and access to the tooltip a lot easier.

tachojelev pushed a commit to IgniteUI/igniteui-docfx that referenced this issue Sep 26, 2018
docfx(tooltip): add tooltip doc page
3c8c1b4 
#IgniteUI/igniteui-angular#1710
@tachojelev tachojelev mentioned this issue Sep 26, 2018
Merged
@Eralmidia
Copy link
Author

Ok. I was thinking it would be possible to stream a template ref from the directive to the igx overlay, and only have a single tooltip component reside there? Still it's a great addition to have a templateable tooltip.

tachojelev pushed a commit that referenced this issue Sep 27, 2018
chore(tooltip): refactoring and new tests #1710
d9a7416
tachojelev pushed a commit that referenced this issue Sep 27, 2018
feat(tooltip): add 'context' input to igxTooltip #1710
8a7a33f
tachojelev pushed a commit that referenced this issue Sep 28, 2018
docs(tooltip): add 'context' property to README #1710
621e9e0
tachojelev pushed a commit to IgniteUI/igniteui-docfx that referenced this issue Sep 28, 2018
docfx(tooltip): update page with new API links
cdf5182 
IgniteUI/igniteui-angular#1710
tachojelev pushed a commit to IgniteUI/igniteui-docfx that referenced this issue Sep 28, 2018
docfx(tooltip): fix sliders position
df41195 
IgniteUI/igniteui-angular#1710
tachojelev pushed a commit to IgniteUI/igniteui-angular-samples that referenced this issue Sep 28, 2018
samples(tooltip): fix sliders position
aff437d 
IgniteUI/igniteui-angular#1710
tachojelev pushed a commit to IgniteUI/igniteui-docfx that referenced this issue Sep 28, 2018
docfx(tooltip): word improvements
0acc098 
IgniteUI/igniteui-angular#1710
tachojelev pushed a commit to IgniteUI/igniteui-docfx that referenced this issue Oct 1, 2018
docfx(tooltip): remove ripple
5b8f6fa 
IgniteUI/igniteui-angular#1710
tachojelev pushed a commit to IgniteUI/igniteui-angular-samples that referenced this issue Oct 1, 2018
samples(tooltip): remove ripple
95b2bdb 
IgniteUI/igniteui-angular#1710
tachojelev pushed a commit to IgniteUI/igniteui-docfx that referenced this issue Oct 1, 2018
docfx(tooltip): fix typos
ca994a9 
IgniteUI/igniteui-angular#1710
tachojelev pushed a commit to IgniteUI/igniteui-docfx that referenced this issue Oct 1, 2018
docfx(tooltip): fix hardcoded links
e25e007 
IgniteUI/igniteui-angular#1710
tachojelev pushed a commit that referenced this issue Oct 3, 2018
docs(tooltip): add missing docs for tooltip classes #1710
a13dfe1
@tachojelev tachojelev mentioned this issue Oct 3, 2018
Merged
tachojelev pushed a commit that referenced this issue Oct 4, 2018
fix(tooltip): fix icons in tooltip demo #1710
586e347
@tachojelev tachojelev mentioned this issue Oct 4, 2018
Merged
@mpavlinov mpavlinov added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StefanIvanov StefanIvanov

@simeonoff simeonoff

@tachojelev tachojelev

@desig9stein desig9stein

@SlavUI SlavUI

Labels
🧰 feature-request tooltip version: 6.2.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@kdinev @StefanIvanov @simeonoff @mpavlinov @zdrawku @tachojelev @Eralmidia @desig9stein @SlavUI