Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IgxGridState is not working with IgxHierarchicalGrid #7025

Closed
bmtheo opened this issue Mar 31, 2020 · 4 comments · Fixed by #7592
Closed

IgxGridState is not working with IgxHierarchicalGrid #7025

bmtheo opened this issue Mar 31, 2020 · 4 comments · Fixed by #7592
Assignees
@hanastasov @radomirchev
Labels
grid: hierarchical-grid grid: state-persistence 🧰 feature-request version: 10.1.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@bmtheo
Copy link

bmtheo commented Mar 31, 2020

Description

When using the IgxGridState directive with IgxHierarchicalGrid it is throwing an error when trying to getState
"ERROR TypeError: Cannot read property 'columns' of null"

  • igniteui-angular version:
    "igniteui-angular": "^9.0.6",
  • browser:
    Tested on Chrome (Version 80.0.3987.149), Firefox (73.0.1) & Edge (Version 80.0.361.69)

Steps to reproduce

https://stackblitz.com/edit/igx-hierarchical-grid-persistence

  1. Move a column around
  2. Click on Save
  3. The error is printed in the console and the state is not saved

Result

Error is printed and state is not usable

Expected result

No error then we can save/restore the state

Attachments

https://stackblitz.com/edit/igx-hierarchical-grid-persistence

Error in Chrome :
image

Error in Firefox :
image

The error in Stackblitz is not printed correctly, please consider reproducing in local to have the full error

Explanation of error

The error occurs in igniteui-angular-js line 59584 in function "getColumns()" (I don't have sourcemap) because this.grid is null.
I think this.grid is null because I'm using IgxHierarchicalGrid and not IgxGrid but I didn't find anything else to use in the doc/code (for example I looked for a IgxHierarchicalGridStateDirective)

I labeled this as a bug because the spec (https://github.com/IgniteUI/igniteui-angular/wiki/Grid-State-Persistence) specifies that it should work with all grids

If I'm mistaken and I just used the wrong directive, please show me the one to use and consider updating the doc
@bmtheo bmtheo added the 🐛 bug Any issue that describes a bug label Mar 31, 2020
@ChronosSF
Copy link
Member

ChronosSF commented Apr 1, 2020 •
edited
Loading

@bmtheo , the IgxGridState directive was only implemented for state persistence of the igxGrid component, not for the Hierarchical or Tree grids. This should be considered a feature request.

@radomirchev radomirchev assigned zdrawku and unassigned zdrawku Apr 2, 2020
@zdrawku
Copy link
Contributor

zdrawku commented Apr 3, 2020

Specification is updated

@radomirchev
Copy link
Contributor

@bmtheo the development of the feature request is starting form the current sprint.

@hanastasov hanastasov added the 🛠️ status: in-development Issues and PRs with active development on them label Apr 22, 2020
hanastasov added a commit that referenced this issue Apr 23, 2020
@hanastasov
feat(grid): add hier grid to state directive #7025
9c1c621
hanastasov added a commit that referenced this issue Apr 27, 2020
@hanastasov
feat(grid): support expansion for all grids #7025
72a59c3
hanastasov added a commit that referenced this issue Apr 27, 2020
@hanastasov
feat(state): add features enum #7025
f6240cd
@hanastasov hanastasov mentioned this issue Apr 27, 2020
Closed
21 tasks
hanastasov added a commit that referenced this issue Apr 27, 2020
@hanastasov
feat(grid): Use featues enum #7025
ae92ee5
hanastasov added a commit that referenced this issue Apr 28, 2020
@hanastasov
test(state): modify tests per latest changes #7025
5ee96d8
hanastasov added a commit that referenced this issue Apr 28, 2020
@hanastasov
fix(state): set default value for groupby #7025
96eb66b
hanastasov added a commit that referenced this issue Apr 29, 2020
@hanastasov
feat(state): refactor state dir dev demo #7025
173116b
hanastasov added a commit that referenced this issue May 4, 2020
@hanastasov
feat(state): Add support for child grids #7025
ce8f829
hanastasov added a commit that referenced this issue May 4, 2020
@hanastasov
feat(state): set the features to work with #7025
ebfd875
hanastasov added a commit that referenced this issue May 4, 2020
@hanastasov
feat(state): pass enabled features children #7025
def2fe9
hanastasov added a commit that referenced this issue May 13, 2020
@hanastasov
feat(state): fix bug add test for hier state #7025
1a7cb0b
@radomirchev
Copy link
Contributor

@bmtheo , the feature request is in the list for the current milestone. You could follow the milestone progress on the Roadmap board or in the Roadmap file

hanastasov added a commit that referenced this issue Jun 19, 2020
@hanastasov
fix(state): use rowParentId to diff grids #7025
dbe0c84
hanastasov added a commit that referenced this issue Jun 19, 2020
@hanastasov
fix(state): iterate deep child grids #7025
fdd7a17
hanastasov added a commit that referenced this issue Jun 19, 2020
@hanastasov
fix(state): use parentRowID to diff grids #7025
3f33705
hanastasov added a commit that referenced this issue Jun 24, 2020
@hanastasov
test(state): refactor test to generate state #7025
01bce6d
hanastasov added a commit that referenced this issue Jun 24, 2020
@hanastasov
test(state): refactor test to generate state #7025
88aaf0e
hanastasov added a commit that referenced this issue Jun 25, 2020
@hanastasov
fix(state): save row pinning in hiergrid #7025
fd9696d
hanastasov added a commit that referenced this issue Jun 25, 2020
@hanastasov
fix(state): keep row pinning state hiergrid #7025
5b7fa73
hanastasov added a commit that referenced this issue Jun 25, 2020
@hanastasov
chore(state): update changelog #7025
089d30d
hanastasov added a commit that referenced this issue Jun 25, 2020
@hanastasov
test(state): fix test to respect rowPinning #7025
5ac839b
hanastasov added a commit that referenced this issue Jun 25, 2020
@hanastasov
test(state): remove f from test #7025
a0dbc99
hanastasov added a commit that referenced this issue Jun 25, 2020
@hanastasov
chore(state): update changelog #7025
df267d4
hanastasov added a commit that referenced this issue Jun 25, 2020
@hanastasov
test(state): fix test to respect rowPinning #7025
3df15a5
hanastasov added a commit that referenced this issue Jun 25, 2020
@hanastasov
test(state): fix test to respect rowPinning #7025
23785cb
hanastasov added a commit that referenced this issue Jun 25, 2020
@hanastasov
test(state): fix test to respect rowPinning #7025
9a9ada5
hanastasov added a commit that referenced this issue Jul 1, 2020
@hanastasov
fix(state): should not return excluded feats #7025
686db70
hanastasov added a commit that referenced this issue Jul 1, 2020
@hanastasov
feat(state): use interface instead of class #7025
fca28d7
hanastasov added a commit that referenced this issue Jul 1, 2020
@hanastasov
fix(state): should not return excluded feats #7025
9d62f97
hanastasov added a commit that referenced this issue Jul 1, 2020
@hanastasov
feat(state): use interface instead of class #7025
59c3744
hanastasov added a commit that referenced this issue Jul 1, 2020
@hanastasov
feat(state): Use GridFeatures typing #7025
8cedc17
hanastasov added a commit that referenced this issue Jul 1, 2020
@hanastasov
test(state): update tests to use rowIslands #7025
5dc55ea
hanastasov added a commit that referenced this issue Jul 1, 2020
@hanastasov
feat(state): Use GridFeatures typing #7025
98449f1
hanastasov added a commit that referenced this issue Jul 1, 2020
@hanastasov
test(state): update tests to use rowIslands #7025
61040c8
hanastasov added a commit that referenced this issue Jul 2, 2020
@hanastasov
feat(state): set proper accessors #7025
f0999b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hanastasov hanastasov

@radomirchev radomirchev

Labels
grid: hierarchical-grid grid: state-persistence 🧰 feature-request version: 10.1.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
5 participants
@ChronosSF @zdrawku @hanastasov @bmtheo @radomirchev