feat(tree-grid): adding matching records only filtering strategy #10077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viktorkombov
added
grid: tree-grid
❌ status: awaiting-test
gedinakova
requested changes
Sep 9, 2021
|
|
||
| expect(treeGrid.rowList.length).toBe(3); | ||
|
|
||
| const filterStrategy = new MatchingRecordsOnlyFilteringStrategy(); |
There was a problem hiding this comment.
Defining this const seems obsolete.
| @@ -74,3 +74,46 @@ export class TreeGridFormattedValuesFilteringStrategy extends TreeGridFilteringS | |||
| return value; | |||
| } | |||
| } | |||
|
|
|||
| export class MatchingRecordsOnlyFilteringStrategy extends TreeGridFilteringStrategy { | |||
There was a problem hiding this comment.
I'd rather have some hint to TreeGrid in the class name.
gedinakova
previously approved these changes
Sep 13, 2021
gedinakova
approved these changes
Sep 14, 2021
ddaribo
added
💥 status: in-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9923
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)