Date range test coverage improvement #7647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into PMiteva/date-range-tests # Conflicts: # projects/igniteui-angular/src/lib/date-range-picker/date-range-picker.component.spec.ts
…nputs - update tests
…I/igniteui-angular into PMiteva/date-range-tests # Conflicts: # projects/igniteui-angular/src/lib/date-range-picker/date-range-picker.component.spec.ts
date-editor: update input format on doCheck and onChanges
…I/igniteui-angular into PMiteva/date-range-tests
- fallback to Intl if getLocaleDateFormat fails - use only displayFormat in single input mode
PlamenaMiteva
added
❌ status: awaiting-test
…into PMiteva/date-range-tests
Lipata
previously approved these changes
Jun 22, 2020
wnvko
previously approved these changes
Jun 22, 2020
projects/igniteui-angular/src/lib/date-range-picker/date-range-picker.component.ts
Outdated
Show resolved
Hide resolved
…tring - add logMissingLocaleSettings
PlamenaMiteva
added
💥 status: in-test
wnvko
approved these changes
Jun 24, 2020
Lipata
approved these changes
Jun 26, 2020
Lipata
pushed a commit
that referenced
this pull request
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7477
Some additional enhancements to the
IgxDateRangePickerComponentare included in this PR:The picker will now accumulate all errors and return them as one object during validation.
Also, in single input mode it will use only
displayFormatfor formatting the input's dates.Additionally, the picker's
displayValueas well as its defaultplaceholder(in single input mode) are governed by Angular'sgetLocaleDateFormatandformatDate. These two methods can fail if a user has defined alocalesetting, but has not registered it in their application via theregisterLocaleDatafunction. In this case the picker will now log warnings and will revert to the browser's locale settings while still adhering to the defineddisplayFormat. If a user has not provided anydisplayFormat, the picker has a default, constant format which will be used instead.Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)