Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add base parent for IgxDatePickerComponent, IgxTimePickerComponent and IgxDateRangePickerComponent #8771

Closed
wants to merge 0 commits into from
Closed

Add base parent for IgxDatePickerComponent, IgxTimePickerComponent and IgxDateRangePickerComponent #8771

wants to merge 0 commits into from

Conversation

jackofdiamond5
Copy link
Member

@jackofdiamond5 jackofdiamond5 commented Jan 11, 2021 •
edited
Loading

Related to #7199

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@jackofdiamond5 jackofdiamond5 force-pushed the bpenkov/pickers-base-parent branch 2 times, most recently from 975a03e to ace5ea7 Compare January 13, 2021 07:42
rkaraivanov
rkaraivanov previously approved these changes Jan 19, 2021
View reviewed changes
@jackofdiamond5 jackofdiamond5 marked this pull request as ready for review January 25, 2021 09:04
@jackofdiamond5 jackofdiamond5 changed the base branch from master to karma-coverage-master January 25, 2021 09:14
Base automatically changed from karma-coverage-master to master January 26, 2021 21:20
@Lipata Lipata changed the base branch from master to pickers-refactoring March 5, 2021 08:37
@Lipata Lipata changed the base branch from pickers-refactoring to master March 5, 2021 08:38
@jackofdiamond5 jackofdiamond5 changed the base branch from master to pickers-refactoring March 8, 2021 09:16
@jackofdiamond5 jackofdiamond5 deleted the bpenkov/pickers-base-parent branch March 20, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkaraivanov rkaraivanov rkaraivanov left review comments

@damyanpetev damyanpetev Awaiting requested review from damyanpetev

@Lipata Lipata Awaiting requested review from Lipata

Assignees
No one assigned
Labels
🕐 time-picker 📅 date-picker 📅 date-range-picker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackofdiamond5 @rkaraivanov