feat(combo): add selectionMode input, #9832 #9901
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorSlavov
added
combo
🛠️ status: in-development
ViktorSlavov
force-pushed
the
vslavov/combo-single-select
branch
from
f7a8e24
to
3fa30b6
Compare
ViktorSlavov
added
❌ status: awaiting-test
wnvko
approved these changes
Jul 21, 2021
| this._selectionMode = val; | ||
| const selection = this.selectedItems(); | ||
| if (this._selectionMode === ComboSelectionMode.single && selection.length > 1) { | ||
| this.setSelection(new Set(this.validateSelectionSize(selection))); |
There was a problem hiding this comment.
No need to validate selection size. setSelection will do this for you.
Suggested change
| this.setSelection(new Set(this.validateSelectionSize(selection))); | |
| this.setSelection(new Set(selection)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9832
Add an input to the combo that allows toggling between selection modes (single / multiple)
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)