Add Tree LOD sample with virtualization #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddaribo
changed the title
MonikaKirkova
added
status: in-test
HUSSAR-mtrela
approved these changes
Jul 17, 2023
|
waiting for review of @rkaraivanov |
rkaraivanov
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #465
Things to consider:
For a virtualized scenario of the remote children,
cascadeselection breaks, since the parent item does not have all its children in the dom. As the current LOD sample is withcascadeselection, if this is left with selectionmultiple, this will not be consistent, if included in the topic.Because the virtualized children do not have an
IgcTreeItemas parent, thelevelcannot be correctly calculated, so the indentation is not rendered properly. TheIgcTreeItem'sdiv[part='indentation']'s width cannot be overriden on app level.When running the sample locally, "ResizeObserver loop limit exceeded" errors are thrown on each scroll. This is marked by @lit-labs/virtualizer as expected. Not exhibited in the sample prototype in CodeSandbox here.