Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add snapshot network network stat print. #105

Merged
merged 8 commits into from
Jul 31, 2022
Merged

Add snapshot network network stat print. #105

merged 8 commits into from
Jul 31, 2022

Conversation

Incarnation-p-lee
Copy link
Owner

Signed-off-by: Pan Li incarnation.p.lee@outlook.com

@Incarnation-p-lee
Add snapshot network network stat print.
50e0c00 
Signed-off-by: Pan Li <incarnation.p.lee@outlook.com>
@restyled-io restyled-io bot mentioned this pull request Jul 31, 2022
Merged
@restyled-io @restyled-commits
Restyled by gofmt (#106)
20ba88c 
Co-authored-by: Restyled.io <commits@restyled.io>
@codecov
Copy link

codecov bot commented Jul 31, 2022 •
edited
Loading

Codecov Report

Merging #105 (d814fb0) into master (1da522f) will increase coverage by 0.22%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
+ Coverage   93.37%   93.59%   +0.22%     
==========================================
  Files          16       16              
  Lines         694      718      +24     
==========================================
+ Hits          648      672      +24     
  Misses         35       35              
  Partials       11       11
Impacted Files Coverage Δ
internal/print/print.go 97.94% <100.00%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1da522f...d814fb0. Read the comment docs.

@Incarnation-p-lee
Add more UT.
d0373e1 
Signed-off-by: Pan Li <incarnation.p.lee@outlook.com>
@Incarnation-p-lee
Merge remote-tracking branch 'origin/panli/print-network-stat-for-sna…
ee74547 
…pshot' into panli/print-network-stat-for-snapshot
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jul 31, 2022
@restyled-io restyled-io bot mentioned this pull request Jul 31, 2022
Merged
restyled-io bot and others added 2 commits July 31, 2022 07:21
@restyled-io @restyled-commits
Restyled by gofmt (#107)
f892e80 
Co-authored-by: Restyled.io <commits@restyled.io>
@Incarnation-p-lee
Resolve comments.
999eda6 
Signed-off-by: Pan Li <incarnation.p.lee@outlook.com>
@pull-request-size pull-request-size bot added size/M and removed size/L labels Jul 31, 2022
@Incarnation-p-lee
Resolve coverage.
599038d 
Signed-off-by: Pan Li <incarnation.p.lee@outlook.com>
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jul 31, 2022
@restyled-io restyled-io bot mentioned this pull request Jul 31, 2022
Merged
@restyled-io @restyled-commits
Restyled by gofmt (#108)
d814fb0 
Co-authored-by: Restyled.io <commits@restyled.io>
@sonarcloud
Copy link

sonarcloud bot commented Jul 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Incarnation-p-lee Incarnation-p-lee merged commit e56e4bd into master Jul 31, 2022
@Incarnation-p-lee Incarnation-p-lee deleted the panli/print-network-stat-for-snapshot branch July 31, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Incarnation-p-lee