Add process thread stat to snapshot. #45

Incarnation-p-lee · 2022-06-25T13:45:56Z

Only threadsCount involved.

Signed-off-by: Pan Li incarnation.p.lee@outlook.com

* Only threadsCount involved. Signed-off-by: Pan Li <incarnation.p.lee@outlook.com>

codecov · 2022-06-25T13:46:38Z

Codecov Report

Merging #45 (4f73413) into master (3e37e2c) will decrease coverage by 0.40%.
The diff coverage is 90.36%.

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
- Coverage   86.71%   86.30%   -0.41%     
==========================================
  Files          10       11       +1     
  Lines         286      314      +28     
==========================================
+ Hits          248      271      +23     
- Misses         30       32       +2     
- Partials        8       11       +3

Impacted Files	Coverage Δ
internal/sampling/sampling_process_thread.go	`83.33% <83.33%> (ø)`
internal/sampling/sampling_process.go	`93.47% <92.85%> (+0.45%)`	⬆️
pkg/snapshot/snapshot.go	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e37e2c...4f73413. Read the comment docs.

guardrails · 2022-06-25T13:46:49Z

All previously detected findings have been fixed. Good job! 👍🎉

We will keep this comment up-to-date as you go along and notify you of any security issues that we identify.

👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

sonatype-lift · 2022-06-25T13:47:19Z

internal/sampling/sampling_process_thread.go

+
+func sampleThreadsCount(pID int) int {
+	filename := fmt.Sprintf("/proc/%d/status", pID)
+	file, err := os.Open(filename)


G304: Potential file inclusion via variable

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]