ENH: Declare converting Point(v) constructors explicit
#3237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area:Core
Leengit
reviewed
Feb 28, 2022
Prevented implicit conversion of a value to `Point`. Aims to avoid possible flaws, like the ones addressed by: Pull request InsightSoftwareConsortium#3225 commit 5b71d63 "BUG: Quick-fix ContourSpatialObject::Update(), LINEAR_INTERPOLATION case" Pull request InsightSoftwareConsortium#3228 commit 12a501c "BUG: Fix `SetCenterInObjectSpace` calls in Registration test" Pull request InsightSoftwareConsortium#3231 commit e4841aa "STYLE: Clarify estimation ray position `RayCastInterpolateImageFunction`" Deleted `Point(nullptr_t)`, especially to avoid `PointType p = 0`.
N-Dekker
force-pushed
the
Point-constructors-explicit
branch
from
2781baa
to
415bad7
Compare
Thanks @Leengit I just added an ITK_LEGACY_REMOVE check, to allow legacy support. Please check the force-push! Note that it does not produce a "deprecate warning", it just allows users to get the old (legacy) behavior back, by ITK_LEGACY_REMOVE=OFF |
dzenanz
approved these changes
Feb 28, 2022
SimonRit
pushed a commit
to RTKConsortium/RTK
that referenced
this pull request
Mar 1, 2022
Compilation errors were purposely introduced by InsightSoftwareConsortium/ITK#3237
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Mar 7, 2022
Until now, this constructor was only declared `explicit` for "future" builds (when `ITK_LEGACY_FUTURE_REMOVE` would be enabled). Follow-up to commit a890962 "ENH: Make Vector construction from scalar value explicit" by Brian Helba, January 26, 2015 Added a _deleted_ `Vector(nullptr_t)` constructor, especially to avoid erroneous user code like `VectorType v = 0`. Analog to: pull request InsightSoftwareConsortium#3237 commit 8825834 ENH: Declare converting `Point(v)` constructors `explicit`
hjmjohnson
pushed a commit
that referenced
this pull request
Mar 9, 2022
Until now, this constructor was only declared `explicit` for "future" builds (when `ITK_LEGACY_FUTURE_REMOVE` would be enabled). Follow-up to commit a890962 "ENH: Make Vector construction from scalar value explicit" by Brian Helba, January 26, 2015 Added a _deleted_ `Vector(nullptr_t)` constructor, especially to avoid erroneous user code like `VectorType v = 0`. Analog to: pull request #3237 commit 8825834 ENH: Declare converting `Point(v)` constructors `explicit`
5 tasks
N-Dekker
added a commit
to SuperElastix/elastix
that referenced
this pull request
Jul 25, 2022
Allowing ITK_LEGACY_REMOVE=0N for ITK version >= 5.3rc04, which made those constructors `explicit`: - ITK pull request InsightSoftwareConsortium/ITK#3237 commit InsightSoftwareConsortium/ITK@8825834 "ENH: Declare converting `Point(v)` constructors `explicit`" - ITK pull request InsightSoftwareConsortium/ITK#3255 commit InsightSoftwareConsortium/ITK@abb88cc "ENH: Make Vector constructor from scalar explicit, unless LEGACY enabled"
N-Dekker
added a commit
to SuperElastix/elastix
that referenced
this pull request
Jul 25, 2022
Allowing ITK_LEGACY_REMOVE=0N for ITK version >= 5.3rc04, which made those constructors `explicit`: - ITK pull request InsightSoftwareConsortium/ITK#3237 commit InsightSoftwareConsortium/ITK@8825834 "ENH: Declare converting `Point(v)` constructors `explicit`" - ITK pull request InsightSoftwareConsortium/ITK#3255 commit InsightSoftwareConsortium/ITK@abb88cc "ENH: Make Vector constructor from scalar explicit, unless LEGACY enabled"
N-Dekker
added a commit
to SuperElastix/elastix
that referenced
this pull request
Jul 25, 2022
Allowing ITK_LEGACY_REMOVE=0N for ITK version >= 5.3rc04, which made those constructors `explicit`: - ITK pull request InsightSoftwareConsortium/ITK#3237 commit InsightSoftwareConsortium/ITK@8825834 "ENH: Declare converting `Point(v)` constructors `explicit`" - ITK pull request InsightSoftwareConsortium/ITK#3255 commit InsightSoftwareConsortium/ITK@abb88cc "ENH: Make Vector constructor from scalar explicit, unless LEGACY enabled"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevented implicit conversion of a value to
Point. Aims to avoidpossible flaws, like the ones addressed by:
Pull request #3225
commit 5b71d63
"BUG: Quick-fix ContourSpatialObject::Update(), LINEAR_INTERPOLATION case"
Pull request #3228
commit 12a501c
"BUG: Fix
SetCenterInObjectSpacecalls in Registration test"Pull request #3231
commit e4841aa
"STYLE: Clarify estimation ray position
RayCastInterpolateImageFunction"Deleted
Point(nullptr_t), especially to avoidPointType p = 0.