-
-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Allow nifti load to fail #3529
BUG: Allow nifti load to fail #3529
Commits on Aug 6, 2022
-
ENH: Force test failure on bad file writing
When attempting to write to an invalid file location, ensure that an itk::ExceptionObject is thrown.
Configuration menu - View commit details
-
Copy full SHA for a8cc0a5 - Browse repository at this point
Copy the full SHA a8cc0a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3dfab27 - Browse repository at this point
Copy the full SHA 3dfab27View commit details -
BUG: Provide itk::Exception for invalid NIFTI write
When attempting to write a nifti file to an invalid location (for example, C:\Windows\something.nii) then no file is created there yet no error is reported. The issue is that the error is swallowed in both niftilib and nifti2 (just "reported" with LNI_FERR macro, which does not throw an exception or reports the error to ITK in any other way): Resolves: InsightSoftwareConsortium#1958
Configuration menu - View commit details
-
Copy full SHA for 3b46b05 - Browse repository at this point
Copy the full SHA 3b46b05View commit details -
ENH: Convert unspecified exceptions to itk
Ensure that caught exceptions are converted to itk::Exception objects.
Configuration menu - View commit details
-
Copy full SHA for 62e307a - Browse repository at this point
Copy the full SHA 62e307aView commit details
Commits on Aug 7, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 6fc1c88 - Browse repository at this point
Copy the full SHA 6fc1c88View commit details -
ENH: Consolidate resetting IO object for reuse
When re-using the HDF IO object, all internal state variables should be reset to the initial state as if the object had been constructed anew. Previously, the WriteImageInformation function would set the value m_ImageInformationWritten to true, and it would never again be set to false.
Configuration menu - View commit details
-
Copy full SHA for a9165bf - Browse repository at this point
Copy the full SHA a9165bfView commit details -
BUG: A temporary work-around for HDF5 testing
The HDF5ImageIO objects are single use for writing. After the initial use, the WriteImageInformation function is short circuited, and can not be reset for writing a second image. This bug was exposed while fixing a problem with the not throwing an exception when attempting to write to a path that does not exist. This temporary work around in the test framework allows fixing the initial problem without requiring fixing the HDF5ImageIO re-use issues. NOTE: Resetting the HDF5ImageIO object at the end of writing fixes the re-use problem for non-streaming case, but that causes the streaming tests to fail.
Configuration menu - View commit details
-
Copy full SHA for f244a81 - Browse repository at this point
Copy the full SHA f244a81View commit details