BUG: Remove timeout-minutes entry from build-test-package.yml #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
360 is already the default. This is marked as invalid by GitHub: https://github.com/InsightSoftwareConsortium/ITKElastix/actions/runs/10372464472/workflow
N-Dekker
approved these changes
Aug 29, 2024
| @@ -11,7 +11,6 @@ on: | |||
| - main | |||
|
|
|||
| jobs: | |||
| timeout-minutes: 360 | |||
There was a problem hiding this comment.
Good catch, Matt! By the way, it looks like timeout-minutes is only supported for a specific job, not for all jobs together:
jobs.<job_id>.timeout-minutes
The maximum number of minutes to let a job run before GitHub automatically cancels it. Default: 360
|
@thewtex The proposed commit looks fine to me, but apparently it still doesn't make the CI happy. Shall we merge it, or would you prefer to fix the CI failures, before merging this PR? |
|
@N-Dekker the existing failure looks unrelated, and that continue to squash other issues as-needed 🚀 🎸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
360 is already the default.
This is marked as invalid by GitHub:
https://github.com/InsightSoftwareConsortium/ITKElastix/actions/runs/10372464472/workflow