Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Update to ITK 5.4 RC 01 #418

Merged
merged 2 commits into from
Jul 26, 2023
Merged

ENH: Update to ITK 5.4 RC 01 #418

merged 2 commits into from
Jul 26, 2023

Conversation

thewtex
Copy link
Member

@thewtex thewtex commented Jul 24, 2023

No description provided.

@github-actions github-actions bot added type:Enhancement Improvement of existing methods or implementation type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots labels Jul 24, 2023
@jhlegarreta
Copy link
Member

Not sure if the following error has made the ubuntu 20.04 build fail:
https://github.com/InsightSoftwareConsortium/ITKSphinxExamples/actions/runs/5652044475/job/15311075291?pr=418#step:9:11328

Tests are passing:
https://github.com/InsightSoftwareConsortium/ITKSphinxExamples/actions/runs/5652044475/job/15311075291?pr=418#step:9:27732

Some warnings that may be unrelated/may need to be addressed in separate PRs:
https://github.com/InsightSoftwareConsortium/ITKSphinxExamples/actions/runs/5652044475/job/15311075291?pr=418#step:9:13129

jhlegarreta
jhlegarreta reviewed Jul 25, 2023
View reviewed changes
Copy link
Member

@jhlegarreta jhlegarreta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thewtex builds are passing now +1 ; time to remove the WIP from the commit subject if it is ready?

@thewtex
COMP: pandoc version for docs build
3370d2a 
To address:

> itkpython/lib/python3.9/site-packages/nbsphinx/__init__.py:1058: RuntimeWarning: You are using an unsupported version of pandoc (2.9.2.1).
@thewtex
Copy link
Member Author

thewtex commented Jul 26, 2023

@jhlegarreta thanks for the reviews and checking!

Yes, the pandoc update did the trick 😅

@thewtex thewtex merged commit 112e57e into InsightSoftwareConsortium:master Jul 26, 2023
13 checks passed
@thewtex thewtex deleted the itk-5.4rc01 branch July 26, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhlegarreta jhlegarreta jhlegarreta left review comments

@tbirdso tbirdso tbirdso approved these changes

Assignees
No one assigned
Labels
type:Enhancement Improvement of existing methods or implementation type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thewtex @jhlegarreta @tbirdso