Displacement field bridge ITK-MONAI #8
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ntatsisk thanks!! @HastingsGreer please take a look 🙏 |
Shadow-Devil
added a commit
to Shadow-Devil/MONAI
that referenced
this pull request
Jan 30, 2023
…and automatically download test data Signed-off-by: Felix Schnabel <f.schnabel@tum.de>
|
I tried to add it into the PR. If you have any feedback, I would highly appreciate it 😄 |
Shadow-Devil
added a commit
to Shadow-Devil/MONAI
that referenced
this pull request
Jan 30, 2023
…and automatically download test data Signed-off-by: Felix Schnabel <f.schnabel@tum.de>
Shadow-Devil
added a commit
to Shadow-Devil/MONAI
that referenced
this pull request
Feb 4, 2023
…and automatically download test data Signed-off-by: Felix Schnabel <f.schnabel@tum.de>
Spenhouet
reviewed
Feb 6, 2023
| return np.asarray(warped_image) | ||
|
|
||
|
|
||
| def monai_wrap(image_tensor, ddf_tensor): |
Shadow-Devil
added a commit
to Shadow-Devil/MONAI
that referenced
this pull request
Feb 7, 2023
…and automatically download test data Signed-off-by: Felix Schnabel <f.schnabel@tum.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can this PR also become part of Project-MONAI/MONAI#5897, @Shadow-Devil @wyli?
cc. @thewtex @HastingsGreer
Related to: Project-MONAI/MONAI#4117
One important note: here I am using simple torch tensors as input for the wrapping functions. This is different from the affine bridge PR where MetaTensors where used. This means that there is a difference in the ordering of dimensions because of this line in the MetaTensor creation https://github.com/Project-MONAI/MONAI/blob/50c3f328cb98e4f0c4e6a38a04a98badf0961c18/monai/data/image_reader.py#L393. To be honest, I am not sure if Tensor or MetaTensor is preferable. Let me know what you think is better for the integration in the MONAI codebase.
--
xref:
Original affine bridge ITK-MONAI: #6
ITKElastix bridge milestone: InsightSoftwareConsortium/ITKElastix#126