Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

context json settings; change dds-server to not use DDS discovery #10386

Merged
merged 4 commits into from
Apr 11, 2022
Merged

context json settings; change dds-server to not use DDS discovery #10386

merged 4 commits into from
Apr 11, 2022

Conversation

maloel
Copy link
Collaborator

@maloel maloel commented Apr 11, 2022 •
edited
Loading

  • rs2::context() now can accept JSON settings
    ** dds-discovery - (bool) false to disable discovery; defaults to true
    ** dds-domain - (int) the domain to use for discovery
  • rs-dds-server now disables discovery

Tracked on [LRS-419]

@maloel maloel requested a review from Nir-Az April 11, 2022 10:50
Nir-Az
Nir-Az reviewed Apr 11, 2022
View reviewed changes
src/context.cpp Outdated Show resolved Hide resolved
Nir-Az
Nir-Az approved these changes Apr 11, 2022
View reviewed changes
Copy link
Collaborator

@Nir-Az Nir-Az left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@maloel maloel merged commit 1d2dc32 into IntelRealSense:dds Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nir-Az Nir-Az Nir-Az approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maloel @Nir-Az