Skip to content

Commit

Permalink
Misc changes (#226)
Browse files Browse the repository at this point in the history
* Misc changes

* Update VSTS images

* Update NuGet test packages

* Revert changes to csproj
  • Loading branch information
slozier committed Apr 24, 2020
1 parent 4d72535 commit 47252ae
Show file tree
Hide file tree
Showing 6 changed files with 22 additions and 12 deletions.
6 changes: 3 additions & 3 deletions .vsts-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ jobs:
displayName: Windows
timeoutInMinutes: 180
pool:
vmImage: windows-2019
vmImage: windows-latest
steps:
- template: Build/steps.yml
parameters:
Expand All @@ -18,7 +18,7 @@ jobs:
displayName: Linux (Ubuntu)
timeoutInMinutes: 180
pool:
vmImage: 'ubuntu-16.04'
vmImage: ubuntu-latest
steps:
- template: Build/steps.yml
parameters:
Expand All @@ -30,7 +30,7 @@ jobs:
displayName: macOS
timeoutInMinutes: 180
pool:
vmImage: 'macOS-10.13'
vmImage: macOS-latest
steps:
- template: Build/steps.yml
parameters:
Expand Down
6 changes: 3 additions & 3 deletions Src/Microsoft.Dynamic/Ast/ConstantExpression.cs
Original file line number Diff line number Diff line change
Expand Up @@ -119,11 +119,11 @@ private static Expression CreateArray<T>(T[] array) {

private static Expression ComplexConstant(Complex value) {
if (value.Real != 0.0) {
if (value.Imaginary() != 0.0) {
if (value.Imaginary != 0.0) {
return Expression.Call(
new Func<double, double, Complex>(MathUtils.MakeComplex).GetMethodInfo(),
Constant(value.Real),
Constant(value.Imaginary())
Constant(value.Imaginary)
);
}

Expand All @@ -135,7 +135,7 @@ private static Expression ComplexConstant(Complex value) {

return Expression.Call(
new Func<double, Complex>(MathUtils.MakeImaginary).GetMethodInfo(),
Constant(value.Imaginary())
Constant(value.Imaginary)
);
}
}
Expand Down
1 change: 1 addition & 0 deletions Tests/ClrAssembly/ClrAssembly.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@

<ItemGroup>
<Compile Include="dummy.cs" />
<None Include="Src\**\*" />
</ItemGroup>

<ItemGroup>
Expand Down
7 changes: 5 additions & 2 deletions Tests/Metadata/Metadata.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,11 @@

<ItemGroup>
<PackageReference Include="NUnitLite" Version="3.12.0" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.4.0" />
<PackageReference Include="NUnit3TestAdapter" Version="3.15.1" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.6.1" />
<PackageReference Include="NUnit3TestAdapter" Version="3.16.1">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
</ItemGroup>

<ItemGroup>
Expand Down
7 changes: 5 additions & 2 deletions Tests/Microsoft.Dynamic.Test/Microsoft.Dynamic.Test.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,11 @@

<ItemGroup>
<PackageReference Include="NUnitLite" Version="3.12.0" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.4.0" />
<PackageReference Include="NUnit3TestAdapter" Version="3.15.1" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.6.1" />
<PackageReference Include="NUnit3TestAdapter" Version="3.16.1">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
</ItemGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,11 @@

<ItemGroup>
<PackageReference Include="NUnitLite" Version="3.12.0" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.4.0" />
<PackageReference Include="NUnit3TestAdapter" Version="3.15.1" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.6.1" />
<PackageReference Include="NUnit3TestAdapter" Version="3.16.1">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
</ItemGroup>

<ItemGroup>
Expand Down

0 comments on commit 47252ae

Please sign in to comment.