Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fresh install of Mirador with no enabled plugins emits PHP Warning #43

Closed
kayakr opened this issue Mar 12, 2024 · 0 comments
Closed
Labels
bug Something isn't working

Comments

@kayakr
Copy link

kayakr commented Mar 12, 2024

What steps does it take to reproduce the issue?

  • Enable Islandora Mirador 2.3.5 and render via Mirador block. Observe 2 instances of "Warning: Undefined array key "miradorImageToolsPlugin" in template_preprocess_mirador() (line 51 of modules/contrib/islandora_mirador/islandora_mirador.module).
  • Enable Islandora Mirador 2.3.5 and render via Mirador block. Observe 2 instances of "Warning: Undefined array key "textOverlayPlugin" in template_preprocess_mirador() (line 51 of modules/contrib/islandora_mirador/islandora_mirador.module).

On L54 of Mirador module https://github.com/Islandora/islandora_mirador/blob/2.x/islandora_mirador.module#L54, need to add isset(), e.g.
if (isset($enabled_plugins[$plugin_id])) {

@kayakr kayakr added the bug Something isn't working label Mar 12, 2024
kayakr pushed a commit to kayakr/islandora_mirador that referenced this issue Mar 12, 2024
alxp added a commit that referenced this issue Mar 13, 2024
#43 Add isset() to prevent PHP warning when no plugins enabled
@alxp alxp closed this as completed Mar 13, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants