Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

39-embiggen Make viewer be 1200 pixels high by default. #40

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Conversation

alxp
Copy link
Contributor

@alxp alxp commented Feb 12, 2024

What does this Pull Request do?

Change the CSS so the viewer is 1200px high rather than 500.

  • Related GitHub Issue: link

What's new?

A in-depth description of the changes made by this PR. Technical details and
possible side effects.

The CSS for teh Mirador block's height attribute changed from 500 to 1200

  • Does this change add any new dependencies?
  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)? No
  • Could this change impact execution of existing code? No

How should this be tested?

On a site that does not have a custom theme overriding the styling of a Mirador block, load the viewer after clearing Drupal's cache. You may need to try opening in a private window to load the latest CSS.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers

@alxp
Copy link
Contributor Author

alxp commented Feb 12, 2024

Screen shot of new larger viewer in Starter site with default theme:

image

@rosiel rosiel merged commit bdd6ec7 into 2.x Feb 12, 2024
@rosiel rosiel deleted the 39-embiggen branch February 12, 2024 20:15
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants