Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.2, fix missing property definition #56

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

adam-vessey
Copy link
Contributor

Just fixing a warning when bumping up to PHP 8.2:

Deprecated function: Creation of dynamic property Drupal\openseadragon\Config::$configFactory is deprecated in Drupal\openseadragon\Config->__construct() (line 54 of modules/contrib/openseadragon/src/Config.php).

Stacktrace
Drupal\openseadragon\Config->__construct(Object) (Line: 259)
Drupal\Component\DependencyInjection\Container->createService(Array, 'openseadragon.config') (Line: 177)
Drupal\Component\DependencyInjection\Container->get('openseadragon.config') (Line: 77)
Drupal\openseadragon\Plugin\Block\OpenseadragonBlock::create(Object, Array, 'openseadragon_block', Array) (Line: 21)
Drupal\Core\Plugin\Factory\ContainerFactory->createInstance('openseadragon_block', Array) (Line: 76)
Drupal\Component\Plugin\PluginManagerBase->createInstance('openseadragon_block', Array) (Line: 62)
Drupal\Core\Plugin\DefaultSingleLazyPluginCollection->initializePlugin('openseadragon_block') (Line: 57)
Drupal\block\BlockPluginCollection->initializePlugin('openseadragon_block') (Line: 80)
Drupal\Component\Plugin\LazyPluginCollection->get('openseadragon_block') (Line: 45)
Drupal\block\BlockPluginCollection->get('openseadragon_block') (Line: 83)
Drupal\Core\Plugin\DefaultSingleLazyPluginCollection->setConfiguration(Array) (Line: 99)
Drupal\Core\Plugin\DefaultSingleLazyPluginCollection->addInstanceId('openseadragon_block', Array) (Line: 55)
Drupal\Core\Plugin\DefaultSingleLazyPluginCollection->__construct(Object, 'openseadragon_block', Array) (Line: 34)
Drupal\block\BlockPluginCollection->__construct(Object, 'openseadragon_block', Array, 'openseadragonblock') (Line: 156)
Drupal\block\Entity\Block->getPluginCollection() (Line: 145)
Drupal\block\Entity\Block->getPlugin() (Line: 118)
Drupal\block\BlockAccessControlHandler->checkAccess(Object, 'view', Object) (Line: 105)
Drupal\Core\Entity\EntityAccessControlHandler->access(Object, 'view', Object, 1) (Line: 314)
Drupal\Core\Entity\EntityBase->access('view', NULL, 1) (Line: 63)
Drupal\block\BlockRepository->getVisibleBlocksPerRegion(Array) (Line: 137)
Drupal\block\Plugin\DisplayVariant\BlockPageVariant->build() (Line: 189)
Drupal\context\Plugin\DisplayVariant\ContextBlockPageVariant->getBuildFromBlockLayout() (Line: 139)
Drupal\context\Plugin\DisplayVariant\ContextBlockPageVariant->build() (Line: 75)
Drupal\context_groups\Plugin\DisplayVariant\ContextGroupsBlockPageVariant->build() (Line: 270)
Drupal\Core\Render\MainContent\HtmlRenderer->prepare(Array, Object, Object) (Line: 128)
Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse(Array, Object, Object) (Line: 90)
Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray(Object, 'kernel.view', Object)
call_user_func(Array, Object, 'kernel.view', Object) (Line: 111)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch(Object, 'kernel.view') (Line: 187)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 704)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

@rosiel rosiel merged commit 4a66979 into 2.x Oct 18, 2023
3 checks passed
@rosiel rosiel deleted the fix/php-8.2-deprecated-dynamic-properties branch October 18, 2023 17:15
ruebot pushed a commit to yorkulibraries/openseadragon that referenced this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants