Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add COI integration to settings form. #57

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Add COI integration to settings form. #57

merged 3 commits into from
Nov 15, 2023

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented Oct 24, 2023

GitHub Issue: Islandora-Devops/islandora-starter-site#112

What does this Pull Request do?

Allows Config Override Inspector (COI) to act on the iiif server url config in openseadragon.

Screenshot 2023-10-24 at 9 37 28 AM

What's new?

  • Lets COI mark this setting as overridden.
  • Does this change require documentation to be updated? no
  • Does this change add any new dependencies? no
  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)? no
  • Could this change impact execution of existing code? no

How should this be tested?

  • Install Openseadragon using a method that uses the settings.php file to override config - for example, the site template currently does this.
  • Visit the form fields for overridden values. You will see the "saved config" value which is overridden so not actually active. You will also be able to change the "saved config" value.
  • Install Config Override Inspector (coi). Before this PR, nothing happens. But with this PR, the Openseadragon settings values are marked as overridden.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers

aOelschlager
aOelschlager approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@aOelschlager aOelschlager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shows up just like the screenshot in the pr.

@aOelschlager aOelschlager mentioned this pull request Nov 15, 2023
Merged
@aOelschlager aOelschlager merged commit ea235a6 into Islandora:2.x Nov 15, 2023
6 checks passed
@rosiel rosiel deleted the coi branch November 15, 2023 18:51
ruebot pushed a commit to yorkulibraries/openseadragon that referenced this pull request Nov 20, 2023
@rosiel @ruebot
Add COI integration to settings form. (Islandora#57)
629226c 
* Add COI integration to settings form.

* Tabs to spaces.

* Composer suggest COI module.
@rosiel rosiel mentioned this pull request Nov 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aOelschlager aOelschlager aOelschlager approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rosiel @aOelschlager