Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR previews should use test database #1335

Closed
tobiasdiez opened this issue Aug 26, 2022 · 1 comment
Closed

PR previews should use test database #1335

tobiasdiez opened this issue Aug 26, 2022 · 1 comment
Labels
p4: important For example a bug that violate documented behavior or significantly improves performance status: blocked Blocked by an issue / missing feature of a dependency, or by another issue type: developer experience

Comments

@tobiasdiez
Copy link
Member

tobiasdiez commented Aug 26, 2022

Currently, the azure pr preview uses the production app settings, in particular the main database.
Changing this requires one of the following to be fixed:

Using

      - name: Login to Azure
        uses: Azure/login@v1
        with:
          creds: ${{secrets.AZURE_CREDENTIALS}}

      - name: Update app settings
        uses: azure/CLI@v1
        with:
          inlineScript: |
            az staticwebapp appsettings set --name jabref-online --setting-names "DATABASE_URL=$DATABASE_URL"
        env:
          DATABASE_URL: ${{ secrets.AZURE_TEST_DATABASE_URL }}

Alternative: #1343

@tobiasdiez tobiasdiez added type: developer experience p4: important For example a bug that violate documented behavior or significantly improves performance status: blocked Blocked by an issue / missing feature of a dependency, or by another issue labels Aug 26, 2022
tobiasdiez added a commit that referenced this issue Aug 27, 2022
Towards fixing #1285

Fix 
> LanguageWorkerConsoleLog[error] Worker
d515a7ff-9c85-424a-9dbb-7ad7c02d98e8 uncaught exception (learn more:
https://go.microsoft.com/fwlink/?linkid=2097909 ): TypeError:
res._implicitHeader is not a function at writetop
(/home/site/wwwroot/functions/node_modules/express-session/index.js:276:15)
at ServerResponse.end
(/home/site/wwwroot/functions/node_modules/express-session/index.js:343:16)
at Immediate.<anonymous>
(file:///home/site/wwwroot/functions/node_modules/h3/dist/index.mjs:138:17)
at processImmediate (internal/timers.js:464:21)

and fixes (hopefully) that azure builds two app instances by running
`yarn build` and `yarn build:azure`

Followup #1335
@tobiasdiez
Copy link
Member Author

Fixed with #1343.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p4: important For example a bug that violate documented behavior or significantly improves performance status: blocked Blocked by an issue / missing feature of a dependency, or by another issue type: developer experience
Projects
None yet
Development

No branches or pull requests

1 participant