Fix for issue 8198, 8133 (#8229)

* Update LibraryPropertiesDialogViewModel.java * Update JabRefPreferences.java * Update SaveOrderConfig.java * Update LibraryPropertiesDialogViewModel.java * Update JabRefPreferences.java * Update SaveOrderConfig.java
JabRef · Nov 14, 2021 · 10a2760 · 10a2760
1 parent d80eb7c
commit 10a2760
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/src/main/java/org/jabref/model/metadata/SaveOrderConfig.java b/src/main/java/org/jabref/model/metadata/SaveOrderConfig.java
@@ -33,12 +33,12 @@ public String toString() {
             return name;
         }
 
-        public static SaveOrderConfig.OrderType fromBooleans(boolean saveInSpecifiedOrder, boolean saveInTableOrder) {
-            SaveOrderConfig.OrderType orderType = SaveOrderConfig.OrderType.ORIGINAL;
+        public static SaveOrderConfig.OrderType fromBooleans(boolean saveInSpecifiedOrder, boolean saveInOriginalOrder) {
+            SaveOrderConfig.OrderType orderType = SaveOrderConfig.OrderType.TABLE;
             if (saveInSpecifiedOrder) {
                 orderType = SaveOrderConfig.OrderType.SPECIFIED;
-            } else if (saveInTableOrder) {
-                orderType = SaveOrderConfig.OrderType.TABLE;
+            } else if (saveInOriginalOrder) {
+                orderType = SaveOrderConfig.OrderType.ORIGINAL;
             }
 
             return orderType;
@@ -67,7 +67,7 @@ private SaveOrderConfig(List<String> data) {
         }
 
         try {
-            this.orderType = OrderType.valueOf(data.get(0));
+            this.orderType = OrderType.valueOf(data.get(0).toUpperCase());
         } catch (IllegalArgumentException ex) {
             if (data.size() > 1 && data.size() % 2 == 1) {
                 LOGGER.warn("Could not parse sort order: {} - trying to parse the sort criteria", data.get(0));

diff --git a/src/main/java/org/jabref/preferences/JabRefPreferences.java b/src/main/java/org/jabref/preferences/JabRefPreferences.java
@@ -157,6 +157,7 @@ public class JabRefPreferences implements PreferencesService {
     public static final String REFORMAT_FILE_ON_SAVE_AND_EXPORT = "reformatFileOnSaveAndExport";
     public static final String EXPORT_IN_ORIGINAL_ORDER = "exportInOriginalOrder";
     public static final String EXPORT_IN_SPECIFIED_ORDER = "exportInSpecifiedOrder";
+
     public static final String EXPORT_PRIMARY_SORT_FIELD = "exportPriSort";
     public static final String EXPORT_PRIMARY_SORT_DESCENDING = "exportPriDescending";
     public static final String EXPORT_SECONDARY_SORT_FIELD = "exportSecSort";
@@ -530,7 +531,7 @@ private JabRefPreferences() {
         defaults.put(REFORMAT_FILE_ON_SAVE_AND_EXPORT, Boolean.FALSE);
 
         // export order
-        defaults.put(EXPORT_IN_ORIGINAL_ORDER, Boolean.FALSE);
+        defaults.put(EXPORT_IN_ORIGINAL_ORDER, Boolean.TRUE);
         defaults.put(EXPORT_IN_SPECIFIED_ORDER, Boolean.FALSE);
 
         // export order: if EXPORT_IN_SPECIFIED_ORDER, then use following criteria