Fix empty fields being added to the entry table preferences

JabRef · May 17, 2023 · 27e5659 · 27e5659
1 parent f166455
commit 27e5659
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -81,6 +81,7 @@ Note that this project **does not** adhere to [Semantic Versioning](http://semve
 - We fixed an issue where passing a URL containing a DOI led to a "No entry found" notification. [#9821](https://github.com/JabRef/jabref/issues/9821)
 - We fixed some minor visual inconsistencies and issues in the preferences dialog. [#9866](https://github.com/JabRef/jabref/pull/9866)
 - The order of save actions is now retained. [#9890](https://github.com/JabRef/jabref/pull/9890)
+- We fixed custom columns being added to entry table prefs, while field text is empty [#9913](https://github.com/JabRef/jabref/issues/9913)
 
 ### Removed
 

diff --git a/src/main/java/org/jabref/gui/preferences/table/TableTabViewModel.java b/src/main/java/org/jabref/gui/preferences/table/TableTabViewModel.java
@@ -193,7 +193,8 @@ private void removeExtraFileColumns() {
     }
 
     public void insertColumnInList() {
-        if (addColumnProperty.getValue() == null) {
+        if (addColumnProperty.getValue() == null ||
+            addColumnProperty.getValue().getQualifier().isEmpty()) {
             return;
         }