Skip to content

Commit

Permalink
Fix the order for conference papers in APA styles (#5875)
Browse files Browse the repository at this point in the history
The current code in the macro date-sort-date is outputting in all
cases the same
   <date variable="issued" form="numeric"/>
except for conference papers with editors etc., where not output
at all is given. Consequently these conference papers will be moved
to the end of a block or the bibliography at all (apa-cv showed this
error instructively. This fixes the macro as discussed in
https://forums.zotero.org/discussion/94197/ .

It updates all styles which where be found with
> grep 'macro name="date-sort-date"' *.csl

Co-authored-by: Brenton M. Wiernik <bwiernik@users.noreply.github.com>
  • Loading branch information
zuphilip and bwiernik committed Jan 31, 2022
1 parent 5125c43 commit 76f23a2
Show file tree
Hide file tree
Showing 18 changed files with 27 additions and 160 deletions.
2 changes: 1 addition & 1 deletion apa-annotated-bibliography.csl
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<category citation-format="author-date"/>
<category field="psychology"/>
<category field="generic-base"/>
<updated>2021-06-10T13:09:49+00:00</updated>
<updated>2022-01-31T14:30:00+00:00</updated>
<rights license="http://creativecommons.org/licenses/by-sa/3.0/">This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License</rights>
</info>
<locale xml:lang="en">
Expand Down
2 changes: 1 addition & 1 deletion apa-cv.csl
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<category citation-format="author-date"/>
<category field="psychology"/>
<category field="generic-base"/>
<updated>2019-12-04T13:09:49+00:00</updated>
<updated>2022-01-31T14:30:00+00:00</updated>
<rights license="http://creativecommons.org/licenses/by-sa/3.0/">This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License</rights>
</info>
<locale xml:lang="en">
Expand Down
2 changes: 1 addition & 1 deletion apa-no-ampersand.csl
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<category citation-format="author-date"/>
<category field="psychology"/>
<category field="generic-base"/>
<updated>2021-06-10T13:09:49+00:00</updated>
<updated>2022-01-31T14:30:00+00:00</updated>
<rights license="http://creativecommons.org/licenses/by-sa/3.0/">This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License</rights>
</info>
<locale xml:lang="en">
Expand Down
2 changes: 1 addition & 1 deletion apa-no-initials.csl
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<category citation-format="author-date"/>
<category field="psychology"/>
<category field="generic-base"/>
<updated>2021-06-10T13:09:49+00:00</updated>
<updated>2022-01-31T14:30:00+00:00</updated>
<rights license="http://creativecommons.org/licenses/by-sa/3.0/">This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License</rights>
</info>
<locale xml:lang="en">
Expand Down
2 changes: 1 addition & 1 deletion apa-numeric-superscript-brackets.csl
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<category field="psychology"/>
<category field="generic-base"/>
<summary>APA style, with numeric in-text citations in brackets</summary>
<updated>2019-12-04T13:09:49+00:00</updated>
<updated>2022-01-31T14:30:00+00:00</updated>
<rights license="http://creativecommons.org/licenses/by-sa/3.0/">This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License</rights>
</info>
<locale xml:lang="en">
Expand Down
2 changes: 1 addition & 1 deletion apa-numeric-superscript.csl
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<category field="psychology"/>
<category field="generic-base"/>
<summary>APA style, with superscript numeric in-text citations</summary>
<updated>2019-12-04T13:09:49+00:00</updated>
<updated>2022-01-31T14:30:00+00:00</updated>
<rights license="http://creativecommons.org/licenses/by-sa/3.0/">This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License</rights>
</info>
<locale xml:lang="en">
Expand Down
2 changes: 1 addition & 1 deletion apa-single-spaced.csl
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<category citation-format="author-date"/>
<category field="psychology"/>
<category field="generic-base"/>
<updated>2021-06-10T13:09:49+00:00</updated>
<updated>2022-01-31T14:30:00+00:00</updated>
<rights license="http://creativecommons.org/licenses/by-sa/3.0/">This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License</rights>
</info>
<locale xml:lang="en">
Expand Down
2 changes: 1 addition & 1 deletion apa-with-abstract.csl
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<category citation-format="author-date"/>
<category field="psychology"/>
<category field="generic-base"/>
<updated>2021-06-10T13:09:49+00:00</updated>
<updated>2022-01-31T14:30:00+00:00</updated>
<rights license="http://creativecommons.org/licenses/by-sa/3.0/">This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License</rights>
</info>
<locale xml:lang="en">
Expand Down
2 changes: 1 addition & 1 deletion apa.csl
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<category citation-format="author-date"/>
<category field="psychology"/>
<category field="generic-base"/>
<updated>2021-06-10T13:09:49+00:00</updated>
<updated>2022-01-31T14:30:00+00:00</updated>
<rights license="http://creativecommons.org/licenses/by-sa/3.0/">This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License</rights>
</info>
<locale xml:lang="en">
Expand Down
19 changes: 2 additions & 17 deletions begell-house-apa.csl
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<category citation-format="author-date"/>
<category field="generic-base"/>
<summary>The author-date variant of the Begell House American Psychological Association style</summary>
<updated>2020-02-20T16:31:00+00:00</updated>
<updated>2022-01-31T14:30:00+00:00</updated>
<rights license="http://creativecommons.org/licenses/by-sa/3.0/">This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License</rights>
</info>
<locale xml:lang="en">
Expand Down Expand Up @@ -225,22 +225,7 @@
</choose>
</macro>
<macro name="date-sort-date">
<choose>
<if type="article-magazine article-newspaper broadcast interview pamphlet personal_communication post post-weblog speech treaty webpage" match="any">
<date variable="issued" form="numeric"/>
</if>
<else-if type="paper-conference">
<!-- Capture 'speech' stored as 'paper-conference' -->
<choose>
<if variable="collection-editor editor editorial-director issue page volume" match="none">
<date variable="issued" form="numeric"/>
</if>
</choose>
</else-if>
<else>
<date variable="issued" form="numeric"/>
</else>
</choose>
<date variable="issued" form="numeric"/>
</macro>
<macro name="date-intext">
<choose>
Expand Down
19 changes: 2 additions & 17 deletions citation-compass-apa-note.csl
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
</author>
<category citation-format="note"/>
<category field="generic-base"/>
<updated>2019-12-04T13:09:49+00:00</updated>
<updated>2022-01-31T14:30:00+00:00</updated>
<rights license="http://creativecommons.org/licenses/by-sa/3.0/">This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License</rights>
</info>
<locale xml:lang="en">
Expand Down Expand Up @@ -238,22 +238,7 @@
</choose>
</macro>
<macro name="date-sort-date">
<choose>
<if type="article-magazine article-newspaper broadcast interview pamphlet personal_communication post post-weblog speech treaty webpage" match="any">
<date variable="issued" form="numeric"/>
</if>
<else-if type="paper-conference">
<!-- Capture 'speech' stored as 'paper-conference' -->
<choose>
<if variable="collection-editor editor editorial-director issue page volume" match="none">
<date variable="issued" form="numeric"/>
</if>
</choose>
</else-if>
<else>
<date variable="issued" form="numeric"/>
</else>
</choose>
<date variable="issued" form="numeric"/>
</macro>
<macro name="date-intext">
<choose>
Expand Down
18 changes: 2 additions & 16 deletions european-review-of-agricultural-economics.csl
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
<category field="social_science"/>
<issn>0165-1587</issn>
<eissn>1464-3618</eissn>
<updated>2021-07-28T07:15:06+00:00</updated>
<updated>2022-01-31T14:30:00+00:00</updated>
<rights license="http://creativecommons.org/licenses/by-sa/3.0/">This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License</rights>
</info>
<locale xml:lang="en">
Expand Down Expand Up @@ -215,21 +215,7 @@
</choose>
</macro>
<macro name="date-sort-date">
<choose>
<if type="article-magazine article-newspaper broadcast interview pamphlet personal_communication post post-weblog speech treaty webpage" match="any">
<date variable="issued" form="numeric"/>
</if>
<else-if type="paper-conference">
<choose>
<if variable="collection-editor editor editorial-director issue page volume" match="none">
<date variable="issued" form="numeric"/>
</if>
</choose>
</else-if>
<else>
<date variable="issued" form="numeric"/>
</else>
</choose>
<date variable="issued" form="numeric"/>
</macro>
<macro name="date-intext">
<choose>
Expand Down
19 changes: 2 additions & 17 deletions fundamental-and-applied-limnology.csl
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<category field="biology"/>
<issn>1863-9135</issn>
<eissn>2363-7110</eissn>
<updated>2021-06-17T13:09:49+00:00</updated>
<updated>2022-01-31T14:30:00+00:00</updated>
<rights license="http://creativecommons.org/licenses/by-sa/3.0/">This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License</rights>
</info>
<locale xml:lang="en">
Expand Down Expand Up @@ -231,22 +231,7 @@
</choose>
</macro>
<macro name="date-sort-date">
<choose>
<if type="article-magazine article-newspaper broadcast interview pamphlet personal_communication post post-weblog speech treaty webpage" match="any">
<date variable="issued" form="numeric"/>
</if>
<else-if type="paper-conference">
<!-- Capture 'speech' stored as 'paper-conference' -->
<choose>
<if variable="collection-editor editor editorial-director issue page volume" match="none">
<date variable="issued" form="numeric"/>
</if>
</choose>
</else-if>
<else>
<date variable="issued" form="numeric"/>
</else>
</choose>
<date variable="issued" form="numeric"/>
</macro>
<macro name="date-intext">
<choose>
Expand Down
19 changes: 2 additions & 17 deletions norsk-apa-manual-note.csl
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
</author>
<category citation-format="note"/>
<category field="generic-base"/>
<updated>2020-01-14T02:24:58+00:00</updated>
<updated>2022-01-31T14:30:00+00:00</updated>
<rights license="http://creativecommons.org/licenses/by-sa/3.0/">This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License</rights>
</info>
<locale xml:lang="nb">
Expand Down Expand Up @@ -212,22 +212,7 @@
</choose>
</macro>
<macro name="date-sort-date">
<choose>
<if type="article-magazine article-newspaper broadcast interview pamphlet personal_communication post post-weblog speech treaty webpage" match="any">
<date variable="issued" form="numeric"/>
</if>
<else-if type="paper-conference">
<!-- Capture 'speech' stored as 'paper-conference' -->
<choose>
<if variable="collection-editor editor editorial-director issue page volume" match="none">
<date variable="issued" form="numeric"/>
</if>
</choose>
</else-if>
<else>
<date variable="issued" form="numeric"/>
</else>
</choose>
<date variable="issued" form="numeric"/>
</macro>
<macro name="date-intext">
<choose>
Expand Down
19 changes: 2 additions & 17 deletions norsk-apa-manual.csl
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<category citation-format="author-date"/>
<category field="psychology"/>
<category field="generic-base"/>
<updated>2020-10-28T12:00:00+00:00</updated>
<updated>2022-01-31T14:30:00+00:00</updated>
<rights license="http://creativecommons.org/licenses/by-sa/3.0/">This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License</rights>
</info>
<locale xml:lang="en">
Expand Down Expand Up @@ -240,22 +240,7 @@
</choose>
</macro>
<macro name="date-sort-date">
<choose>
<if type="article-magazine article-newspaper broadcast interview pamphlet personal_communication post post-weblog speech treaty webpage" match="any">
<date variable="issued" form="numeric"/>
</if>
<else-if type="paper-conference">
<!-- Capture 'speech' stored as 'paper-conference' -->
<choose>
<if variable="collection-editor editor editorial-director issue page volume" match="none">
<date variable="issued" form="numeric"/>
</if>
</choose>
</else-if>
<else>
<date variable="issued" form="numeric"/>
</else>
</choose>
<date variable="issued" form="numeric"/>
</macro>
<macro name="date-intext">
<choose>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<category citation-format="author-date"/>
<category field="social_science"/>
<summary>Zitierstil entsprechend den Zitierrichtlinien des Lehrstuhls Betriebswirtschaftslehre, insbesondere betriebliches Rechnungwesen und Controlling, der Fakultät Wirtschaftswissenschaften, Technische Universität Dresden.</summary>
<updated>2020-10-15T12:00:00+00:00</updated>
<updated>2022-01-31T14:30:00+00:00</updated>
<rights license="http://creativecommons.org/licenses/by-sa/3.0/">This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License</rights>
</info>
<locale xml:lang="de">
Expand Down Expand Up @@ -222,22 +222,7 @@
</choose>
</macro>
<macro name="date-sort-date">
<choose>
<if type="article-magazine article-newspaper broadcast interview pamphlet personal_communication post post-weblog speech treaty webpage" match="any">
<date variable="issued" form="numeric"/>
</if>
<else-if type="paper-conference">
<!-- Capture 'speech' stored as 'paper-conference' -->
<choose>
<if variable="collection-editor editor editorial-director issue page volume" match="none">
<date variable="issued" form="numeric"/>
</if>
</choose>
</else-if>
<else>
<date variable="issued" form="numeric"/>
</else>
</choose>
<date variable="issued" form="numeric"/>
</macro>
<macro name="date-intext">
<choose>
Expand Down
19 changes: 2 additions & 17 deletions ucl-university-college-apa.csl
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
</contributor>
<category citation-format="author-date"/>
<category field="generic-base"/>
<updated>2020-11-04T04:07:19+00:00</updated>
<updated>2022-01-31T14:30:00+00:00</updated>
<rights license="http://creativecommons.org/licenses/by-sa/3.0/">This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License</rights>
</info>
<locale xml:lang="da">
Expand Down Expand Up @@ -214,22 +214,7 @@
</choose>
</macro>
<macro name="date-sort-date">
<choose>
<if type="article-magazine article-newspaper broadcast interview pamphlet personal_communication post post-weblog speech treaty webpage" match="any">
<date variable="issued" form="numeric"/>
</if>
<else-if type="paper-conference">
<!-- Capture 'speech' stored as 'paper-conference' -->
<choose>
<if variable="collection-editor editor editorial-director issue page volume" match="none">
<date variable="issued" form="numeric"/>
</if>
</choose>
</else-if>
<else>
<date variable="issued" form="numeric"/>
</else>
</choose>
<date variable="issued" form="numeric"/>
</macro>
<macro name="date-intext">
<choose>
Expand Down
18 changes: 2 additions & 16 deletions university-of-gothenburg-apa-7th-edition-swedish-legislations.csl
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<category citation-format="author-date"/>
<category field="law"/>
<summary>This is a edited version of American Psychological Association 7th edition for University of Gothenburg with support for references to Swedish legislations, motions, propositions and Official Reports of the Swedish Government through the use of the Zotero item type "statute" (författning), for use in Swedish and English.</summary>
<updated>2021-02-15T15:25:56+00:00</updated>
<updated>2022-01-31T14:30:00+00:00</updated>
<rights license="http://creativecommons.org/licenses/by-sa/3.0/">This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License</rights>
</info>
<macro name="author-bib">
Expand Down Expand Up @@ -188,21 +188,7 @@
</choose>
</macro>
<macro name="date-sort-date">
<choose>
<if type="article-magazine article-newspaper broadcast interview pamphlet personal_communication post post-weblog speech treaty webpage" match="any">
<date variable="issued" form="numeric"/>
</if>
<else-if type="paper-conference">
<choose>
<if variable="collection-editor editor editorial-director issue page volume" match="none">
<date variable="issued" form="numeric"/>
</if>
</choose>
</else-if>
<else>
<date variable="issued" form="numeric"/>
</else>
</choose>
<date variable="issued" form="numeric"/>
</macro>
<macro name="date-intext">
<choose>
Expand Down

0 comments on commit 76f23a2

Please sign in to comment.